Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multiline translations in Po files are not written correctly #28

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

vorlif
Copy link
Owner

@vorlif vorlif commented Dec 7, 2023

Summary

If a translation in a Po file went over several lines, it was not encoded correctly. This had no effect on the translation function, only on the export of Po files.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (62ed167) 87.78% compared to head (1db9649) 87.78%.

Files Patch % Lines
catalog/po/encoder.go 60.00% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   87.78%   87.78%           
=======================================
  Files          43       43           
  Lines        4061     4061           
=======================================
  Hits         3565     3565           
  Misses        353      353           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vorlif vorlif merged commit 12024d6 into main Dec 7, 2023
13 checks passed
@vorlif vorlif deleted the fix/po-encoding branch December 7, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants