Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go v1.21 to tests #23

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add go v1.21 to tests #23

merged 1 commit into from
Nov 28, 2023

Conversation

vorlif
Copy link
Owner

@vorlif vorlif commented Nov 28, 2023

Summary

  • Remove support for Golang v1.17 and v1.18
  • Add Golang v1.21 to the tests
  • Lint customizations

@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a1a735e) 87.70% compared to head (0a9579c) 87.76%.

Files Patch % Lines
catalog/poplural/ast/scanner.go 66.66% 1 Missing and 2 partials ⚠️
catalog/po/encoder.go 66.66% 1 Missing ⚠️
catalog/po/scanner.go 66.66% 1 Missing ⚠️
catalog/poplural/ast/parser.go 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   87.70%   87.76%   +0.05%     
==========================================
  Files          43       43              
  Lines        4058     4053       -5     
==========================================
- Hits         3559     3557       -2     
+ Misses        356      353       -3     
  Partials      143      143              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vorlif vorlif merged commit 7c4622b into main Nov 28, 2023
13 checks passed
@vorlif vorlif deleted the feature/go-v1.21 branch December 3, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants