feature: Details Block

[luukbrauckmann]

Changes

• Adds new Details Block

Associated issue

Resolves #171

How to test

1. Open preview link
2. Navigate to /en/demos/page-partial-layouts/
3. You can also check Dato.

Checklist

• I have performed a self-review of my own code
• I have made sure that my PR is easy to review (not too big, includes comments)
• I have made updated relevant documentation files (in project README, docs/, etc)
• I have added a decision log entry if the change affects the architecture or changes a significant technology
• I have notified a reviewer

[luukbrauckmann]

I'm a bit conflicted by the name DetailsBlock. If I would use this I would expect to render a details element, but maybe that's because I'm a developer who knows html. I suggest I rename it to DefinitionsBlock or DefinitionListBlock?

Also I added for now the | (pipe) character for separating multiple values. I could make this an option in which you can enter the split character in Dato, so the content editors can decide on a per block basis what they want to the split character to be. Does this sound like a good idea or overkill?

[cloudflare-workers-and-pages]

Deploying head-start with    Cloudflare Pages

Latest commit:	68fc8bf
Status:	✅  Deploy successful!
Preview URL:	https://3fce157e.head-start.pages.dev
Branch Preview URL:	https://feat-171-details-block.head-start.pages.dev

View logs

[jbmoelker]

Nice work @luukbrauckmann! Left small comments.

[jbmoelker]

Please make sure to also include the migration for this block in the PR. We might be blocked by #164 by this 🤷 .

[jbmoelker]

I would also trim the value, so in the CMS editors can write "a | b | c" instead of "a|b|c", so splitValue.trim()

[jbmoelker]

@luukbrauckmann you've already made some good iterations on this PR 🙌. As @decrek remarked and as we discussed, we could achieve this functionality as a variation on the Page Partial Block, rather than introducing a new one. We prefer that approach as it reduces the number of components we need to maintain and footprint we provide to developers using Head Start. What prompted the discussion and is another benefit to reusing the Page Partial Block, is that it allows for richer content in the detail list items (like text formatting and links).