Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Block Context #120

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feature: Block Context #120

wants to merge 1 commit into from

Conversation

jbmoelker
Copy link
Member

@jbmoelker jbmoelker commented Jan 24, 2024

Changes

  • ...
  • handle context of blocks nested in structured text fields
  • handle context of blocks in page partial layouts
  • document block context in docs/blocks-and-components.md

Associated issue

Resolves #114

How to test

Checklist

  • I have performed a self-review of my own code
  • I have made sure that my PR is easy to review (not too big, includes comments)
  • I have made updated relevant documentation files (in project README, docs/, etc)
  • I have added a decision log entry if the change affects the architecture or changes a significant technology
  • I have notified a reviewer

todo: handle context of blocks nested in structured text fields
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a5bd5d6
Status: ✅  Deploy successful!
Preview URL: https://e8dbb0e7.head-start.pages.dev
Branch Preview URL: https://feat-block-context.head-start.pages.dev

View logs

@jbmoelker
Copy link
Member Author

@decrek what do you think, worth exploring the concept of Block Context further or not worth the extra complexity it introduces?

@jbmoelker
Copy link
Member Author

@jurgenbelien I see a project where you introduced the concept of a "theme block" as a container for multiple blocks. Is that so blocks in the same container are context aware? Would this feature solve that same issue without the need for a theme block?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block context
1 participant