Use a proper namespace for this project #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrv
commented
Jul 18, 2024
This confuses tools that parse .gitignore for other purposes and git itself sometimes.
Additionally: - Remove the fs namespace alias from headers - Wrap most global functions in the namespace
prmoore77
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Wow - you did a lot of work, @felipecrv ! It looks great - I've learned a lot already from you. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of defining symbols inside of the namespace of the projects we use (e.g. arrow). There are two problems with this: risk of nasty linker errors if symbols collide and difficulties in understanding from which project a symbol comes from (is it a class defined in this project or a class from Arrow).
Defining template aliases in headers is not recommended, but for convenience one alias is defined:
flight = arrow::flightsince we reference this namespace a lot from the code. Many aliases that were defined in .h files are now removed.