Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened against the wrong repository. The upstream replacement is pingdotgg#29244.
Linux boot-service setup writes outside systemd's search path when its XDG configuration directory is relocated. The installer shell can also disagree with the running user manager about that directory.
Resolve the unit directory from the destination systemd user manager's
UnitPath, using the existingbusctlJSON pattern so paths with spaces survive. All lifecycle operations share that directory. When the manager cannot be queried, fall back to an absoluteXDG_CONFIG_HOMEorHOME/.config.Proof: the relocated-XDG regression failed before the fix; the existing lifecycle test now covers default/empty/relative/relocated roots, both shell/manager mismatch directions, and lookup failure. A read-only runtime probe confirmed the resolved path matches the live manager for four caller environments on Linux arm64 with 16 KiB pages. No real service was installed or enabled; x86_64 was not tested.
Validation:
flock /tmp/t3-linux-audit-heavy-checks.lock vp run check:changed origin/main --concurrency 1passed (format, lint, both Knip passes, GraphQL generation, affected typechecks, and 42 tests). The focused seven-case lifecycle run also passed with--maxWorkers 1.Runtime transcript (manager queried through
busctl --user --json=short get-property … UnitPath;BootService.make/statusonly):Reviewed with review-loop: 2 rounds with Claude Opus 5.5 on high. Reviewer verdict: approved.
Created with GPT-6.1 Sol in the Codex harness.