Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ARM Linux Build using cross-rs #1696

Merged
merged 8 commits into from
Feb 17, 2024
Merged

Create ARM Linux Build using cross-rs #1696

merged 8 commits into from
Feb 17, 2024

Conversation

charlespierce
Copy link
Contributor

@charlespierce charlespierce commented Feb 16, 2024

Info

  • We already support both ARM and x64 for macOS, we can do the same for Linux with cross-rs without needing too much extra work.
  • Since this is a new build that we haven't previously supported, we don't need to adhere to the same binary compatibility guarantees that we are currently using for x64 Linux.

Changes

  • Updated the release.yml GitHub actions file to also generate an ARM build for Linux
    • This takes advantage of cross-rs, which makes the compilation process very straightforward and fast.
  • Updated volta-install.sh to properly handle Linux ARM builds.

Tested

  • Downloaded the artifacts generated in CI and validated that they work in a Linux Docker container on an ARM MacBook.

Notes

  • Do we also need to update COMPATIBILITY.md to reflect the slightly more complicated compatibility that we support (since the ARM builds are made on a newer system)?

@charlespierce charlespierce changed the title Testing potential ARM Linux build with cross Create ARM Linux Build using cross-rs Feb 16, 2024
Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid overall! I’ll mull on the question re: COMPATIBILITY.md but I definitely don’t think we need to block on it. 👍🏼

@this-is-tobi
Copy link

Hello, thanks for the work, it's exciting to continue using volta on any type of system !

Just a question, is there a release planned to get the new linux-arm64 binary ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants