[fix] Adding a default value for RayWorkerGroup.from_detached(name_prefix=None)
#1838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongpeng Guo <[email protected]>
vermouth1992
approved these changes
Jun 4, 2025
7 tasks
vermouth1992
pushed a commit
that referenced
this pull request
Jun 5, 2025
### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? Follow-up of #1838, make the `name_prefix` mechanism same for `RayWorkerGroup` and `RayResourcePool`, default to be `None` and will be initialized randomly. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [x] Rely on existing unit tests on CI that covers the code path. Signed-off-by: Hongpeng Guo <[email protected]>
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jun 6, 2025
…refix=None)` (volcengine#1838) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? In volcengine#1443, a new argument `name_prefix` was introduced for function `from_detached` without setting a default value. This PR sets its default value as `None`, in which case, `RayWorkerGroup` will generate a random string as the prefix. This fix makes the API compatible with existing usage, and the users don't need to worry about this new args when a `name_prefix` is not not context necessary. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [x] Rely on existing unit tests on CI that covers the code path. Signed-off-by: Hongpeng Guo <[email protected]>
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
Jun 6, 2025
…e#1851) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? Follow-up of volcengine#1838, make the `name_prefix` mechanism same for `RayWorkerGroup` and `RayResourcePool`, default to be `None` and will be initialized randomly. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [x] Rely on existing unit tests on CI that covers the code path. Signed-off-by: Hongpeng Guo <[email protected]>
wwwjn
pushed a commit
to wwwjn/verl
that referenced
this pull request
Jun 10, 2025
…refix=None)` (volcengine#1838) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? In volcengine#1443, a new argument `name_prefix` was introduced for function `from_detached` without setting a default value. This PR sets its default value as `None`, in which case, `RayWorkerGroup` will generate a random string as the prefix. This fix makes the API compatible with existing usage, and the users don't need to worry about this new args when a `name_prefix` is not not context necessary. ### Checklist Before Submitting - [x] Read the [Contribute Guide](https://github.com/volcengine/verl?tab=readme-ov-file#contribution-guide). - [x] Apply [pre-commit checks](https://github.com/volcengine/verl?tab=readme-ov-file#code-linting-and-formatting). - [ ] Add `[BREAKING]` to the PR title if it breaks any API. - [ ] Update the documentation about your changes in the [docs](https://github.com/volcengine/verl/tree/main/docs). - [ ] New CI unit test(s) are added to cover the code path. - [x] Rely on existing unit tests on CI that covers the code path. Signed-off-by: Hongpeng Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
In #1443, a new argument
name_prefixwas introduced for functionfrom_detachedwithout setting a default value. This PR sets its default value asNone, in which case,RayWorkerGroupwill generate a random string as the prefix. This fix makes the API compatible with existing usage, and the users don't need to worry about this new args when aname_prefixis not not context necessary.Checklist Before Submitting
[BREAKING]to the PR title if it breaks any API.