delete reservation plugin doc #3546
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/L
Signed-off-by: LX <[email protected]>
hwdef
force-pushed
the
delete-reservation-docs
branch
from
bc9fc21
to
772857c
Compare
|
/assign @Monokaix @lowang-bh |
|
have the problems mentioned in this doc been resolved? |
|
I think the reservation plugin has been deprecated and replaced by the SLA plugin. |
| @@ -1,148 +0,0 @@ | |||
| # Volcano Resource Reservation For Target Jobs | |||
There was a problem hiding this comment.
Maybe we should have a deprecated directory and put this design document in it instead of deleting it directly. This way users can also refer to the previous documents. @Monokaix WDYT
There was a problem hiding this comment.
Maybe we should have a deprecated directory and put this design document in it instead of deleting it directly. This way users can also refer to the previous documents. @Monokaix WDYT
If users want to view old documents, they can switch to the old branch
There was a problem hiding this comment.
We can mark it as deprecated and delete it in next version: )
There was a problem hiding this comment.
@Monokaix
how to mark it as deprecated? write in title? create a deprecated folder?
There was a problem hiding this comment.
I think we can just edit the doc directly: ), and whether it's sovled by sla-plugin should also be checked.
Reservation plugin has been deleted. This doc is no longer needed. It will confuse users.
Additionally, I recommend cleaning up documents that have expired.