Feature/configurable hashing and encoding #336
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Password hashing #️⃣
Password hashing process is hard-coded and can't be modified in any kind. There are cases where we do need control on how password is hashed:
Confirming/Recovering tokens ✉️
Reasons for unhardcoding this part:
Problematic part 🔴 :
authboss.go
has a public helper functionVerifyPassword
, that now works only if we use defaultHasher
. a todo item is left there in comments, explaining the issueFixes #319, #288