Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify actions and use mamba #573

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Simplify actions and use mamba #573

merged 1 commit into from
Jun 12, 2020

Conversation

martinRenou
Copy link
Member

No description provided.

@SylvainCorlay
Copy link
Member

Now that we can drop 3.5, rebasing should get the tests to pass.

@martinRenou

@martinRenou martinRenou force-pushed the simplify_actions branch 3 times, most recently from 4df5ce3 to 860f08f Compare June 2, 2020 07:25
@jtpio
Copy link
Member

jtpio commented Jun 11, 2020

Linking to the conversation on gitter: https://gitter.im/QuantStack/Lobby?at=5ee247be36589658b12b9026

We might want to try with setup-miniconda action, and even enable mamba.

It might even help fixing #526 too.

@jtpio
Copy link
Member

jtpio commented Jun 11, 2020

wow thanks @martinRenou for the update. Let's see how it goes!

@martinRenou
Copy link
Member Author

I'll enable Windows too, see what happens

@jtpio
Copy link
Member

jtpio commented Jun 11, 2020

Windows used to be an issue because of xeus-cling (but there could be a condition to handle that)

@martinRenou
Copy link
Member Author

Looks like python refers to the /usr/bin one, not the conda installed one.

@jtpio
Copy link
Member

jtpio commented Jun 11, 2020

The other jobs (ubuntu and macos) are passing, nice 👍

We could also fix windows separately.

@martinRenou
Copy link
Member Author

Yeah although there is still one failing on Macos. I'll look at it later.

@martinRenou
Copy link
Member Author

martinRenou commented Jun 12, 2020 •
edited
Loading

I rerun the test and it's now passing. There might be a race condition in the tests.

Let's disable Windows tests for now and merge then.

@martinRenou
Copy link
Member Author

@jtpio All green. Ok to merge?

@jtpio
Copy link
Member

jtpio commented Jun 12, 2020

That looks good and much simpler, thanks a lot!

Happy to go for it if we're fine using mamba on CI.

@martinRenou martinRenou merged commit 68e5e66 into voila-dashboards:master Jun 12, 2020
@martinRenou martinRenou deleted the simplify_actions branch June 12, 2020 09:30
@martinRenou martinRenou changed the title Simplify actions Simplify actions and use mamba Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinRenou @SylvainCorlay @jtpio