-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention jupyter server extension in the tests docs #253
Conversation
But how can it run on travis then? I don't see we execute this in travis.yml. Any idea? |
I think |
And travis does: |
cc @martinRenou if you want to give it a try. |
That might mean that some of the files in share are not added to data_files in setup.py? I would expect the opposite behaviour actually. |
I don't think data files are installed at all with |
I meant without (sorry for the confusion). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that fixed it for me :) (tried with a newly created environment)
Ok, that makes more sense. |
We could also have a custom develop cmd, like we do here: setup.py will be a monster though. |
Yes it would be great if the develop command could take care of that. We can create a follow-up issue and see if it makes sense to add it to the |
Will be merging this one for now, since it solves the original issue of being able to run the tests locally. |
Fixes #220.
The reason why the tests mentioned in #220 were failing when running locally is because they required the Jupyter server extension to be enabled. Enabled with the
jupyter extension
command (notjupyter serverextension
).This change adds this information to the contributing guide.