Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention jupyter server extension in the tests docs #253

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jun 17, 2019

Fixes #220.

The reason why the tests mentioned in #220 were failing when running locally is because they required the Jupyter server extension to be enabled. Enabled with the jupyter extension command (not jupyter serverextension).

This change adds this information to the contributing guide.

@maartenbreddels
Copy link
Member

But how can it run on travis then? I don't see we execute this in travis.yml. Any idea?

@jtpio
Copy link
Member Author

jtpio commented Jun 17, 2019

I think pip install with without the -e picks up the server extensions automatically because the data files will end up at the right place.

@jtpio
Copy link
Member Author

jtpio commented Jun 17, 2019

And travis does: pip install ".[test]"

@jtpio
Copy link
Member Author

jtpio commented Jun 17, 2019

cc @martinRenou if you want to give it a try.

@maartenbreddels
Copy link
Member

That might mean that some of the files in share are not added to data_files in setup.py? I would expect the opposite behaviour actually.

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Jun 17, 2019

I think pip install with the -e picks up the server extensions automatically because the data files will end up at the right place.

I don't think data files are installed at all with -e.

@jtpio
Copy link
Member Author

jtpio commented Jun 18, 2019

pip install with the -e

I meant without (sorry for the confusion).

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that fixed it for me :) (tried with a newly created environment)

@maartenbreddels
Copy link
Member

Ok, that makes more sense.

@maartenbreddels
Copy link
Member

We could also have a custom develop cmd, like we do here:
https://github.com/mariobuikhuizen/voila-vuetify/blob/master/setup.py#L50

setup.py will be a monster though.

@jtpio
Copy link
Member Author

jtpio commented Jun 18, 2019

Yes it would be great if the develop command could take care of that.

We can create a follow-up issue and see if it makes sense to add it to the setup.py later on.

@jtpio
Copy link
Member Author

jtpio commented Jun 18, 2019

Will be merging this one for now, since it solves the original issue of being able to run the tests locally.

@jtpio jtpio merged commit 7f7fedf into voila-dashboards:master Jun 18, 2019
@jtpio jtpio deleted the docs-tests branch June 18, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are not passing
4 participants