Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add top-level serverextension and installation instructions #182

Merged
merged 3 commits into from
Jun 4, 2019

Conversation

ivanov
Copy link
Contributor

@ivanov ivanov commented Jun 4, 2019

Here's what the output looks like with these modest changes

$ jupyter serverextension enable voila
Enabling: voila
- Writing config: /home/pi/.jupyter
    - Validating...
      voila 0.0.13 OK

and

$ jupyter serverextension list
config dir: /home/pi/.jupyter
    voila  enabled
    - Validating...
      voila 0.0.13 OK

@ivanov
Copy link
Contributor Author

ivanov commented Jun 4, 2019

this is a smaller scope version than #161, but makes the serverextension work with just a top-level enable voila, instead of having to use enable voila.serverextension

@SylvainCorlay
Copy link
Member

$ jupyter serverextension enable voila

I think that we should probably recommend the --sys-prefix option.

Otherwise, people may be surprised that this is not conda-environment specific or that enabling the extension requires more privileges than installing the package.

@ivanov
Copy link
Contributor Author

ivanov commented Jun 4, 2019

👍 alright, wrote in --sys-prefix as the only preferred way of installing.

@SylvainCorlay SylvainCorlay merged commit ba8af37 into voila-dashboards:master Jun 4, 2019
@jtpio jtpio mentioned this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants