0.4.x: Lazy loading of widgets packages, for ipywidgets 7 and 8 support #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
martinRenou
commented
Jul 16, 2024
Closed
The output widget shows up properly, though the test fails to run half the time due to jupyter_client
trungleduc
reviewed
Jul 17, 2024
trungleduc
approved these changes
Jul 17, 2024
|
Thanks @martinRenou |
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy load the widgets extensions upon request: wait for the first widget creation (coming from the kernel) before loading the controls/base extension.
Remaining TODO:
Lazy load output widget for 7There is nothing we can do here, the https://github.com/jupyter-widgets/ipywidgets/blob/main/packages/output/src/output.ts#L3 version was not bumped between 7 and 8 so we need to stick to one available version