Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Voila #1387

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Update Voila #1387

merged 3 commits into from
Sep 4, 2023

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Aug 25, 2023 •
edited
Loading

References

Update Voila components to help downstream usage.

Code changes

  • Refactor VoilaApp
  • Refactor VoilaFileBrowser
  • Show the loading spinner immediately
  • Add theme name to the lab template

User-facing changes

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch trungleduc/voila/update-template

@trungleduc trungleduc changed the title Update template Update Voila Aug 28, 2023
@trungleduc trungleduc marked this pull request as ready for review September 4, 2023 09:10
martinRenou
martinRenou approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@martinRenou martinRenou merged commit 253ba77 into voila-dashboards:main Sep 4, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trungleduc @martinRenou