JupyterLab 4 support #1343
Merged
JupyterLab 4 support #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
trungleduc
added
enhancement
for more information, see https://pre-commit.ci
martinRenou
requested changes
Jul 5, 2023
martinRenou
reviewed
Jul 6, 2023
|
Thank you !! |
|
Yeah! |
jtpio
reviewed
Jul 17, 2023
| @@ -140,3 +140,19 @@ class VoilaConfiguration(traitlets.config.Configurable): | |||
| help="""Size of pre-heated kernel pool for each notebook. Zero or negative number means disabled. | |||
| """, | |||
| ) | |||
|
|
|||
| extension_whitelist = List( | |||
There was a problem hiding this comment.
Maybe 0.5.0 could be a good time to switch to allowlist and denylist?
Since it was also suggested in #725.
jtpio
reviewed
Jul 17, 2023
| "@voila-dashboards/jupyterlab-preview", | ||
| "@jupyter/collaboration-extension", | ||
| ] | ||
| must_have_extensions = ["@jupyter-widgets/jupyterlab-manager"] |
There was a problem hiding this comment.
Maybe required_extensions would also work as an alternative to must_have_extensions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
#1304
Code changes
User-facing changes
VoilaConfiguration:VoilaConfiguration.extension_whitelist: The list of enabled JupyterLab extensions, ifNone, all extensions are loaded.This setting has higher priority than the
extension_blacklistVoilaConfiguration.extension_blacklist: The list of disabled JupyterLab extensions, ifNone, all extensions are loadedBackwards-incompatible changes
Theme and template config are renamed:
voila-theme->themevoila-template->templateTheme argument now is the theme name displayed in JupyterLab and not the name of the theme python package.