Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined manager #106

Merged
merged 1 commit into from
Jun 15, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 10, 2019

WidgetManager takes a manager as a second argument which was not defined in this case, resulting in a: ReferenceError: manager is not defined

Tested with:

from ipywidgets import IntSlider, Label, Output

out = Output()
slider = IntSlider(min=0, max=100)
label = Label(value='Test')

@out.capture()
def on_change(change):
    display(label)

slider.observe(on_change, names='value')

with out:
    display(slider)    
out

Although this change seems to fix the manager is not defined error, the code posted above still doesn't work as expected (need more investigation).

@SylvainCorlay
Copy link
Member

Sorry this fell between the cracks. Will investigate this week.

@SylvainCorlay
Copy link
Member

(rebased)

@SylvainCorlay
Copy link
Member

The issue with displaying widgets in an output widget appears to be unrelated to this (but related to the issue people experienced with ipympl at the workshop).

Will be merging this and iterate on the output widget.

@jtpio
Copy link
Member Author

jtpio commented Jun 15, 2019

Sounds good, seems to be a different issue indeed.

@SylvainCorlay SylvainCorlay merged commit ae11640 into voila-dashboards:master Jun 15, 2019
@jtpio jtpio deleted the undefined-manager branch June 15, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants