-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for ipywidgets 8 #1046
feat: support for ipywidgets 8 #1046
Conversation
Any news on this topic (ipywidgets 8.0.0b1 support) ? |
I believe we will not be making a Voila release compatible with ipywidgets 8 before it is actually out. Because it would make Voila dependent on ipywidgets 8, and we don't want that yet. |
Thanks @mariobuikhuizen for doing the update 👍 There is some overlap with #846 which also updates to ipywidgets 8. But it could be nice to do the update separately like in this PR so it could then be released in a |
f3420ea
to
dbced04
Compare
FYI @mariobuikhuizen I rebased this branch to fix the conflicts and updated to the latest (final) This looks good locally: |
ipympl==0.8.7 | ||
ipyvolume | ||
ipympl==0.9.2 | ||
ipyvolume @ git+https://github.com/jtpio/ipyvolume@ipywidgets-8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @maartenbreddels it would be great to have a release of ipyvolume
with support for ipywidgets
8: widgetti/ipyvolume#411, thanks!
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2022-09-06 12:40:32.282740782 +0000
+++ /dev/fd/62 2022-09-06 12:40:32.282740782 +0000
@@ -4,37 +4,37 @@
"BENCHMARK_REFERENCE": "actual"
},
"browsers": {
- "chromium": "97.0.4666.0"
+ "chromium": "94.0.4595.0"
},
"systemInformation": {
"cpu": {
- "brand": "Xeon® Platinum 8370C",
+ "brand": "Xeon® E5-2673 v3",
"cache": {
- "l1d": 98304,
+ "l1d": 65536,
"l1i": 65536,
- "l2": 2097152,
- "l3": 50331648
+ "l2": 524288,
+ "l3": 31457280
},
"cores": 2,
"family": "6",
- "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+ "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
"governor": "",
"manufacturer": "Intel®",
- "model": "106",
+ "model": "63",
"physicalCores": 2,
"processors": 1,
"revision": "",
"socket": "",
- "speed": 2.8,
+ "speed": 2.4,
"speedMax": null,
"speedMin": null,
- "stepping": "6",
+ "stepping": "2",
"vendor": "GenuineIntel",
"virtualization": false,
"voltage": ""
},
"mem": {
- "total": 7281307648
+ "total": 7291699200
},
"osInfo": {
"arch": "x64",
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.15.0-1017-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
- "release": "20.04.4 LTS",
- "serial": "1658ea69262c46798282e5c326bee33b",
+ "release": "20.04.3 LTS",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's not wait for ipyvolume to get updated. We only depend on it for visual regression tests anyway.
assuming we grabbing voila-dashboards/voila#1046
Code changes