Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed tests on CI #1014

Merged
merged 5 commits into from
Oct 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:

- name: Install Dependencies
run: |
python -m pip install -U pip jupyterlab~=3.0 jupyter_packaging~=0.10
python -m pip install -U pip jupyterlab~=3.0 jupyter_packaging~=0.10 'nbclassic!=0.3.3'

- name: Install the Voilà Preview JupyterLab extension
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ui-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:

- name: Install dependencies
run: |
python -m pip install --upgrade pip jupyterlab~=3.0 numpy bqplot matplotlib ipympl ipyvolume scipy
python -m pip install --upgrade pip jupyterlab~=3.0 numpy bqplot matplotlib ipympl==0.8.0 ipyvolume scipy
python -m pip install ".[test]"
jlpm
jlpm build
Expand Down
3 changes: 1 addition & 2 deletions tests/app/preheat_activation_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,7 @@ async def test_render_time_with_multiple_requests(http_server_client,
wait=wait)
time_list.append(time)

assert max(time_list) > TIME_THRESHOLD # Render time for a normal kernel
assert min(time_list) < TIME_THRESHOLD # Render time for a preheated kernel
assert time_list[1] > time_list[0] # Render time for a normal kernel is bigger than a a preheated kernel


async def test_request_with_query(http_server_client, base_url):
Expand Down
2 changes: 1 addition & 1 deletion ui-tests/tests/voila.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ test.describe('Voila performance Tests', () => {
const testFunction = async () => {
await page.goto(`render/${notebookName}.ipynb`);
await page.waitForSelector(
'div.jupyter-widgets.jupyter-matplotlib-canvas-container'
'div.jupyter-widgets.jupyter-matplotlib-canvas-container canvas'
);
};
await addBenchmarkToTest(notebookName, testFunction, testInfo, browserName);
Expand Down
Binary file modified ui-tests/tests/voila.test.ts-snapshots/ipympl-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.