Add a separate line for jupyter server extension enable in README
#1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proposed change tries to clean up a bit of confusion about the server extension workflow. I was running into an issue like voila-dashboards#561 . However, I wanted to keep my Jupyter install as a system package on Arch (obligatory "arch, btw!") rather than switching to conda. Thus, the addition of `--sys-prefix` to `jupyter serverextension enable` was not an option for me. There's no Arch/AUR package for Voila just yet (I might make one later), so I'm using Voila via `pip install --user`. However, I found out in https://github.com/voila-dashboards/voila/blob/88d55eaa418f497cc338a4a0602c961449b76de4/.binder/postBuild that `jupyter serverextension` and `jupyter server extension` are two different concepts. I tried running `jupyter server extension enable --user voila`, and, well... voila! It works now. So I'd like to propose this change as a "hey, this is confusing in the documentation; perhaps let's change it up in places!" idea.
|
|
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2021-10-14 07:58:53.568979430 +0000
+++ /dev/fd/62 2021-10-14 07:58:53.568979430 +0000
@@ -8,27 +8,27 @@
},
"systemInformation": {
"cpu": {
- "brand": "Xeon® Platinum 8272CL",
+ "brand": "Xeon® E5-2673 v3",
"cache": {
"l1d": 65536,
"l1i": 65536,
- "l2": 2097152,
- "l3": 36700160
+ "l2": 524288,
+ "l3": 31457280
},
"cores": 2,
"family": "6",
- "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+ "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
"governor": "",
"manufacturer": "Intel®",
- "model": "85",
+ "model": "63",
"physicalCores": 2,
"processors": 1,
"revision": "",
"socket": "",
- "speed": 2.6,
+ "speed": 2.4,
"speedMax": null,
"speedMin": null,
- "stepping": "7",
+ "stepping": "2",
"vendor": "GenuineIntel",
"virtualization": false,
"voltage": ""
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.8.0-1042-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
"release": "20.04.3 LTS",
- "serial": "6c19bc2f6263432da3d31804b6f46a17",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
|
Thanks @StanczakDominik!
|
jtpio
reviewed
Oct 14, 2021
Comment on lines
+77
to
+78
| jupyter serverextension enable voila | ||
| jupyter server extension enable voila |
There was a problem hiding this comment.
If we want to be more specific, we could even add comments such as:
Suggested change
| jupyter serverextension enable voila | |
| jupyter server extension enable voila | |
| # if you are using the classic notebook server | |
| jupyter serverextension enable voila | |
| # if you are using Jupyter Server | |
| jupyter server extension enable voila |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change tries to clean up a bit of confusion about the server extension workflow.
I was running into an issue like #561 . However, I wanted to keep my Jupyter install as a system package on Arch (obligatory "arch, btw!") rather than switching to conda. Thus, the addition of
--sys-prefixtojupyter serverextension enablewas not an option for me. I thus triedjupyter serverextension enable voila, but to no avail.There's no Arch/AUR package for Voila just yet (I might make one later), so I'm using Voila via
pip install --user.However, I found out in https://github.com/voila-dashboards/voila/blob/88d55eaa418f497cc338a4a0602c961449b76de4/.binder/postBuild that
jupyter serverextensionandjupyter server extensionare two different concepts (no idea why, honestly). I tried runningjupyter server extension enable --user voila, and, well... voila! It works now.So I'd like to propose this change as a "hey, this is confusing in the documentation; perhaps let's change it up in places!" idea.
References
Addresses similar problems to #561
Code changes, User-facing changes, Backwards-incompatible changes
None whatsoever; just a README change. I'd be happy to also improve the docs once I get better understanding of why this is necessary.