Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release with PR #730 and #731? #737

Closed
paugier opened this issue Oct 8, 2020 · 6 comments
Closed

New release with PR #730 and #731? #737

paugier opened this issue Oct 8, 2020 · 6 comments

Comments

@paugier
Copy link

paugier commented Oct 8, 2020

With recent versions of Voilà (> 0.1.21), ipympl figures are not shown for users using Firefox or Safari (see #693 and #729). The web browsers used by people is not something that one can control so all voilà applications using ipympl are broken for some users.

This was fixed with PR #730 and #731. (Thanks @maartenbreddels!)

However, since pip install git+https://github.com/voila-dashboards/voila.git#egg=voila does not seem to work (or maybe is very very very slow), I don't see how we can use these fixes for applications hosted on Binder or Heroku.

Moreover, it seems that there is a bug with Voila 0.1.21 and Heroku, so it is not possible to have voila apps using ipympl hosted on Heroku that work for users using Firefox or Safari.

All that to say that a release including #730 and #731 would be very useful 🙂

@pelson
Copy link

pelson commented Oct 15, 2020

This would be indeed useful. In in the prototype phase and was caught out by the linked bugs and am currently shipping a built sdist from master in my project to install on openshift (same approach would be possible with heroku).

@pelson
Copy link

pelson commented Oct 15, 2020

P.S. It was my first time using voila yesterday, and it is really quite awesome! Great job all! 👍

@maartenbreddels
Copy link
Member

I agree we should have a new release, I'll probably get to it next week! (if someone else doesn't get to it first)

@pelson
Copy link

pelson commented Oct 20, 2020

Thanks for doing this! https://pypi.org/project/voila/0.2.4/ 🎉

@maartenbreddels
Copy link
Member

Hah, you are quick to notice :). Thanks!

@pelson
Copy link

pelson commented Oct 20, 2020

Using it already in prod 😂

paugier added a commit to paugier/plot-covid19-fr that referenced this issue Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants