-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gmail compatibility using Emoji #41
Comments
Returning to this and trying to think what might be the best solution... The conflicting line: https://github.com/voidlabs/versafix-template/blob/master/template-def/template-versafix-1.htmml#L342C1-L342C41 Maybe turning
And then adding this class to all existing images in the template? |
Of course this is a bug from Gmail, so I'd treat it as a bug in Gmail, and put a specific workaround instead of altering the way we deal with things. My first attempt at fixing this would be something similar: or maybe, even better, something more gmail specific: (This should be reported to Google that should add to their replaced emoji some inline style or some !important css overriding the email css) |
Thanks @bago
|
Let me know if it works. |
@bago I deployed |
@bago, I'm realizing that this patch doesn't fix the problem in the end. The styles are applied before the email is sent and before Google converts the emojis into images. It must have been set incorrectly when I tested, sorry. I think the solution needs to go in the direction pointed in this other comment #41 (comment) restricting the scope of the display:block for images. |
I looked at this and I think the best options is to simply change Note that the content of " I also think maybe it is safer to move the img rule at the end of its style block (sometimes css parsers stop parsing the whole thing when they found rules they don't understand). |
Thangks @bago. It works |
Currently, if you try to insert an emoji in a versafix-template, clients like Gmail convert the emoji into
img
element. In versafix, all img elements are styled withdisplay:block
. It's not possible to get an inline emoji for example in a section title.Mosaico visualization
Gmail inbox visualization
The text was updated successfully, but these errors were encountered: