Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed dependencies that were preventing IDE builds #92

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fixed dependencies that were preventing IDE builds #92

merged 2 commits into from
Oct 11, 2024

Conversation

w1gs
Copy link
Contributor

@w1gs w1gs commented Oct 6, 2024

This PR fixes issues that were preventing the full IDE from being built. Mainly the original-fs dependency was added as it's required in the out/bootstrap-amd.js file. Additionally, it moves the diff dev dependency in the extension to the main extension dependencies since this was preventing the extension from loading in the compiled IDE.

Error in compiled IDE related to diff package:

image

Code where original-fs dependency is required:

image

@jcommaret
Copy link
Contributor

@andrewpareles The fix worked perfectly ! Thank you @w1gs

I am giving me a little pause to write some documentation for Mac OS ARM ;)

@andrewpareles andrewpareles merged commit 247a3b7 into voideditor:main Oct 11, 2024
@w1gs w1gs deleted the ide-fixes branch October 11, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants