Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update VS source to more recent version #29

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

quant-eagle
Copy link
Contributor

@quant-eagle quant-eagle commented Sep 19, 2024

Description

This PR refactors core VS Code modules and resolves issues with local development setup. The primary outcome is that the project now works properly when run locally, particularly via bash scripts/code.sh.

Key Changes

  • Refactored import paths across base, platform, workbench, and editor modules
  • Updated VS Code source to ensure proper referencing of imports
  • Incorporated recent VS Code fixes and improvements
  • Modified local development scripts and configurations

Main Outcome

  • The project now runs successfully via bash scripts/code.sh
  • Local development environment is fully functional

How Has This Been Tested?

  • Successfully ran bash scripts/code.sh multiple times
  • Tested full local development workflow
  • Verified functionality across different modules (base, platform, workbench, editor)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves code quality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@mathewpareles mathewpareles merged commit d3fd539 into voideditor:main Sep 19, 2024
@quant-eagle quant-eagle deleted the fix/codelens_imports branch September 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants