Skip to content

Conversation

@realsn0w
Copy link
Contributor

Testing the changes

  • I tested the changes in this PR: YES

@realsn0w realsn0w force-pushed the golangci-lint-1.64.5 branch 3 times, most recently from 3f05399 to 1c48626 Compare February 22, 2025 20:51
@realsn0w realsn0w force-pushed the golangci-lint-1.64.5 branch from 1c48626 to ff51ce1 Compare March 3, 2025 12:46
@realsn0w realsn0w changed the title golangci-lint: update to 1.64.5. golangci-lint: update to 1.64.6. Mar 3, 2025
@realsn0w realsn0w force-pushed the golangci-lint-1.64.5 branch from ff51ce1 to 045380b Compare March 18, 2025 12:06
@realsn0w realsn0w changed the title golangci-lint: update to 1.64.6. golangci-lint: update to 1.64.8. Mar 18, 2025
@grafov
Copy link
Contributor

grafov commented Mar 25, 2025

@realsn0w , thank for the patch! This problem really affected already several versions of golangci, including latest v2.0.1. May be we should offer this patch to the golangci-lint project?

UPD. Oh, I see you already pushed patch about another problem related to 32bit tests. It seems authors of golangci-lint just don't take in care 32 bit platforms.

@realsn0w
Copy link
Contributor Author

May be we should offer this patch to the golangci-lint project?

i already did some work with the upstreams for this :)

the broken fieldalign test was disabled on 32bit after some discussion as of v1.64.6 (golangci/golangci-lint@53d58e8), and ninil addressed the uintptr overflows in Antonboom/nilnil@69c833a (released as part of v1.1.0, picked up by golangci-lint with v2.0.0 yesterday).

however, it seems like gci's update of nilnil was slightly botched and only pulled in new tests without updating the existing ones, so the overflowing constants still exist in their vendored copy. i/we may need to make another PR for that.

i can close this PR in favor of your new one.
feel free to copy over the patch until upstream has accepted a fix, it works for v2 as well.

@grafov
Copy link
Contributor

grafov commented Mar 25, 2025

Thank you for the clarification! And thanks to your patch, I now understand where to search for the problems. The CI logs from previous failed builds of golangci were quite frustrating to me :)

Well I'll copy your patch to #54852 as is.

@realsn0w realsn0w closed this Mar 25, 2025
@realsn0w realsn0w deleted the golangci-lint-1.64.5 branch May 27, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants