Skip to content

Conversation

@tornaria
Copy link
Contributor

@tornaria tornaria commented Apr 1, 2023

Fixes a bug that affects numpy/scipy/octave/sagemath

See: OpenMathLib/OpenBLAS#3976

Testing the changes

  • I tested the changes in this PR: briefly

I had >100 test failures in sagemath with 0.3.22_1 that should all be fixed in 0.3.23.

@ahesford

@ahesford
Copy link
Member

ahesford commented Apr 1, 2023

Let's wait on these patches and revert instead. Upstream hasn't yet accepted the most recent one and, given the extent of these issues, I'd rather let the fixes settle into a new release rather than trying to squash these bugs with patches.

@martin-frbg
Copy link

0.2.23 is to be released this weekend, you can bet I'll run the latest versions of the numpy/scipy testsuites this time in addition to OpenBLAS' own. (And thanks for confirming that this fixes all of sagemath's testsuite errors too)

@ahesford ahesford marked this pull request as draft April 1, 2023 11:26
@ahesford
Copy link
Member

ahesford commented Apr 1, 2023

@tornaria I reverted Void's package pending final upstream testing and a new release. If you want to use this PR to manage the update to 0.3.23, feel free to keep it open.

@martin-frbg
Copy link

released 0.3.23 just now

@tornaria tornaria changed the title openblas: fix bug that affects numpy/scipy/octave/sagemath openblas: update to 0.23.3. Apr 2, 2023
@tornaria tornaria changed the title openblas: update to 0.23.3. openblas: update to 0.3.23. Apr 2, 2023
@tornaria
Copy link
Contributor Author

tornaria commented Apr 2, 2023

I will run sagemath testsuite and report back when I'm done.

@tornaria
Copy link
Contributor Author

tornaria commented Apr 3, 2023

@ahesford everything looks ok now. I've tested sagemath with this, locally and in #43225.

@ahesford ahesford closed this in 5f94d13 Apr 4, 2023
@tornaria tornaria deleted the openblas branch April 4, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants