Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godot: update to 4.0.3. #41675

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

dataCobra
Copy link
Contributor

@dataCobra dataCobra commented Jan 16, 2023

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)

Godot 4.0 is released!

Please test the PR on different architectures and give feedback here about the usability.

@classabbyamp
Copy link
Member

We could consider adding this PR to Void but since beta will be obsolete with Godot 4 release I wouldn't recommend it.

betas wouldn't be accepted anyways

@dataCobra dataCobra changed the title [WIP] New package: godot-beta [WIP] Draft for change from Godot 3 to 4. Jan 16, 2023
@paper42 paper42 marked this pull request as draft January 16, 2023 09:57
@dataCobra dataCobra force-pushed the godot-beta branch 2 times, most recently from 11dc4c7 to af404e8 Compare January 18, 2023 08:59
@lun-4
Copy link
Contributor

lun-4 commented Mar 1, 2023

Now that Godot 4 is released, maybe we can work on revitalizing this PR?

@dataCobra
Copy link
Contributor Author

dataCobra commented Mar 1, 2023

Definitly, I'll work on this. 👍

@dataCobra dataCobra changed the title [WIP] Draft for change from Godot 3 to 4. [WIP] Upgrade Godot 3 to Godot 4 Mar 1, 2023
@dataCobra dataCobra changed the title [WIP] Upgrade Godot 3 to Godot 4 Upgrade Godot 3 to Godot 4 Mar 1, 2023
@dataCobra dataCobra changed the title Upgrade Godot 3 to Godot 4 Upgrade Godot from 3 to 4 Mar 1, 2023
@dataCobra dataCobra marked this pull request as ready for review March 1, 2023 19:17
@dataCobra
Copy link
Contributor Author

Everyone who is willing to test the building and try out the PR please let me know if everything works as expected.

@dataCobra
Copy link
Contributor Author

For me it works on x86_64-glibc

@dataCobra
Copy link
Contributor Author

For some currently unknown reason the new version of embree is no longer working with Godot.

Because of this I've changed the configuration so it fallsback to builtin embree for now.

@jstnas
Copy link
Contributor

jstnas commented Mar 5, 2023

Tested this on x86_64-musl and it does work, but I had to add libexecinfo-devel to the makedepends

@dataCobra
Copy link
Contributor Author

Hey @jstnas,

thank you for testing the PR.

Can you please test again?

I've now added libexecinfo-devel for all *-musl architectures.

@jstnas
Copy link
Contributor

jstnas commented Mar 8, 2023

I've rebuilt the package and everything's working as expected.

@dataCobra
Copy link
Contributor Author

Thanks for testing @jstnas 👍

@zen0bit
Copy link
Contributor

zen0bit commented Mar 21, 2023

4.01 is out

@jstnas
Copy link
Contributor

jstnas commented Mar 21, 2023

testing 4.0.1 on x86_64-musl, Godot crashed when built without speech-dispatcher-devel

@eljamm
Copy link
Contributor

eljamm commented Mar 21, 2023

I tested 4.0.1 on x86_64-glibc and everything seems to be working fine.

@dataCobra
Copy link
Contributor Author

I've pushed the new template for 4.0.1 taking the dependency for musl into account.

Can you please test the package again?

@dataCobra
Copy link
Contributor Author

I forgot to change the checksum...

Will push again. ^^

@dataCobra
Copy link
Contributor Author

Alright, now with the correct checksum. 👍

@dataCobra dataCobra changed the title godot: update to 4.0.2. godot: update to 4.0.3. May 25, 2023
@bilebucket
Copy link
Contributor

I had a brief test and the package indeed seems to work just fine.

@eljamm
Copy link
Contributor

eljamm commented May 28, 2023

Everything seems good to me as well.

@obunden
Copy link
Contributor

obunden commented Jun 2, 2023

Would you guys say that this is ready for merging? Or is something untested?

@bilebucket
Copy link
Contributor

I'd say that it's good to merge. I've worked on a 2D project of mine with this package for some 7 hours, no instability or crashes occurred. I also briefly tested some of the available 3D demos and they seem to work well too. @dataCobra thank you for maintaining the Godot package!

@dataCobra dataCobra force-pushed the godot-beta branch 2 times, most recently from b6f57e2 to 34dbf1d Compare June 16, 2023 11:30
srcpkgs/godot/template Outdated Show resolved Hide resolved
@leahneukirchen
Copy link
Member

Please rebase and push so we can run CI for once. (I'm not 100% sure libexecinfo is picked up.)

@dataCobra
Copy link
Contributor Author

Please rebase and push so we can run CI for once. (I'm not 100% sure libexecinfo is picked up.)

CI is now running. :)

I hope we get a good outcome.

@dataCobra
Copy link
Contributor Author

dataCobra commented Jun 29, 2023

Well i686 fails but I don't quite understand what the problem is.

The system should be building x86 and not x86_64 but compliance about x86_64 not build?

As said before, building here natively x86 did work.

@astralchan
Copy link
Contributor

astralchan commented Jul 1, 2023

Well i686 fails but I don't quite understand what the problem is.

The system should be building x86 and not x86_64 but compliance about x86_64 not build?

As said before, building here natively x86 did work.

https://docs.godotengine.org/en/stable/contributing/development/compiling/introduction_to_the_buildsystem.html#architecture

Architecture

The arch option is meant to control the CPU or OS version intended to run the binaries. It is focused mostly on desktop platforms and ignored everywhere else.

Supported values for the arch option are auto, x86_32, x86_64, arm32, arm64, rv64, ppc32, ppc64 and wasm32.

scons platform=<platform> arch={auto|x86_32|x86_64|arm32|arm64|rv64|ppc32|ppc64|wasm32}

This flag appends the value of arch to resulting binaries when relevant. The default value arch=auto detects the architecture that matches the host platform.

In theory, specifying arch=x86_32 would work, no?

@dataCobra dataCobra force-pushed the godot-beta branch 2 times, most recently from 8323677 to 534ec0f Compare July 2, 2023 07:12
@dataCobra
Copy link
Contributor Author

dataCobra commented Jul 2, 2023

It seems like with all the great help we've a functioning update.

If you stumble upon any other issues please let me know. Otherwise I would say we're finally ready for merge. 🙂

Thanks a lot to all of you.

@leahneukirchen leahneukirchen merged commit 1dca94c into void-linux:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.