-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
godot: update to 4.0.3. #41675
godot: update to 4.0.3. #41675
Conversation
betas wouldn't be accepted anyways |
11dc4c7
to
af404e8
Compare
Now that Godot 4 is released, maybe we can work on revitalizing this PR? |
Definitly, I'll work on this. 👍 |
Everyone who is willing to test the building and try out the PR please let me know if everything works as expected. |
For me it works on x86_64-glibc |
For some currently unknown reason the new version of embree is no longer working with Godot. Because of this I've changed the configuration so it fallsback to builtin embree for now. |
Tested this on |
Hey @jstnas, thank you for testing the PR. Can you please test again? I've now added |
I've rebuilt the package and everything's working as expected. |
Thanks for testing @jstnas 👍 |
4.01 is out |
testing 4.0.1 on x86_64-musl, Godot crashed when built without |
I tested 4.0.1 on x86_64-glibc and everything seems to be working fine. |
I've pushed the new template for 4.0.1 taking the dependency for musl into account. Can you please test the package again? |
I forgot to change the checksum... Will push again. ^^ |
Alright, now with the correct checksum. 👍 |
I had a brief test and the package indeed seems to work just fine. |
Everything seems good to me as well. |
Would you guys say that this is ready for merging? Or is something untested? |
I'd say that it's good to merge. I've worked on a 2D project of mine with this package for some 7 hours, no instability or crashes occurred. I also briefly tested some of the available 3D demos and they seem to work well too. @dataCobra thank you for maintaining the Godot package! |
b6f57e2
to
34dbf1d
Compare
390d477
to
951b51e
Compare
Please rebase and push so we can run CI for once. (I'm not 100% sure libexecinfo is picked up.) |
CI is now running. :) I hope we get a good outcome. |
Well i686 fails but I don't quite understand what the problem is. The system should be building x86 and not x86_64 but compliance about x86_64 not build? As said before, building here natively x86 did work. |
In theory, specifying |
8323677
to
534ec0f
Compare
It seems like with all the great help we've a functioning update. If you stumble upon any other issues please let me know. Otherwise I would say we're finally ready for merge. 🙂 Thanks a lot to all of you. |
Testing the changes
Local build testing
Godot 4.0 is released!
Please test the PR on different architectures and give feedback here about the usability.