Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] New package: deno-1.0.0 #22043

Closed
wants to merge 1 commit into from
Closed

Conversation

toluschr
Copy link
Contributor

@toluschr toluschr commented May 17, 2020

#21937

I think the do_install function would need to be changed a little, however the cargo build helper throws an error.

@q66
Copy link
Contributor

q66 commented May 17, 2020

unless you figure out how to make it not fetch binaries during build, this cannot be accepted

@toluschr
Copy link
Contributor Author

At which step does it fetch binaries? The terminal log mentioned compiling the dependencies

@Johnnynator
Copy link
Member

The musl log makes it clear: https://travis-ci.org/github/void-linux/void-packages/jobs/688065967#L4665 Also 30min on travis is not close to the time v8 would need to compile.

@Johnnynator
Copy link
Member

rusty_v8 doc:

Use V8_FROM_SOURCE=1 cargo build -vv to build the crate completely from source.
https://github.com/denoland/rusty_v8

@toluschr
Copy link
Contributor Author

rusty_v8 doc:

Use V8_FROM_SOURCE=1 cargo build -vv to build the crate completely from source.
https://github.com/denoland/rusty_v8

Thanks for the help! I will change the template accordingly.

@toluschr
Copy link
Contributor Author

The musl build is still failing for some reason. I did a little research and found this:
rust-lang/rust#61328
rust-lang/rust#59302
but neither of those two tips fixed the issue. Maybe someone with a little more knowledge can help?

@toluschr toluschr changed the title New package: deno-1.0.0 [WIP] New package: deno-1.0.0 May 17, 2020
@atk
Copy link
Contributor

atk commented Jun 23, 2020

I'm working on the more recent version, see https://github.com/atk/void-packages/tree/deno-1.1.1 - do you want to team up?

@toluschr
Copy link
Contributor Author

I'm working on the more recent version, see https://github.com/atk/void-packages/tree/deno-1.1.1 - do you want to team up?

I'm not sure I can help you with that. I tried to create a template for an hour and gave up.

@atk
Copy link
Contributor

atk commented Jun 24, 2020

I found the issue not to be musl itself, but the lack of a gn package (https://gn.googlesource.com/gn/) to be utilized by cargo-gn that is required to build a few of the other internal dependencies.

@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@ericonr
Copy link
Member

ericonr commented Dec 20, 2020

Superseded by #25436

@ericonr ericonr closed this Dec 20, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-package This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants