-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mklive.sh: simplify generate_squashfs() #311
Conversation
Tested on i686. Works and solves the issue #292. |
That's not related to this PR, any new build of an iso would solve that issue. |
Thank you for testing :) |
That's interesting, other reports suggested that rebuilding the iso is enough to make it work and that it was just a random fs corruption. |
OK, I can imagine that this might be caused by the fact that I've been using a privileged Docker container to build the iso. I'll try again on a real void installation to exclude this suspicion... |
OK, so my suspicion is confirmed. The issue occurs only with Docker. In a normal system, it works almost as expected. (The installer is still missing certain packages, like dialog and grub and maybe more if not explicitly specified using -p) |
That's expected if you ran just mklive.sh, you are supposed to run build-x86-packages.sh -b base if you want the base iso. |
That's an important information. Is there any documentation on that? |
Unfortunately no, but there is an open issue about documenting this repository: #126. |
This boots successfully when written as-is to a USB drive, but fails to boot as loopback from grub (dracut iso-scan/dmsquash-live). Not the same kind of bug as #294; it gets past the point of mounting the squashfs (and seemingly figuring out it's the actual rootfs), but fails to change the root. Possibly a dracut bug. As for #292, it is caused by the ext3 rootfs image within the squashfs being corrupted. This PR bypasses its creation; can't get corrupted it if doesn't exist. |
Thank you for testing 😉
Yep. |
Does it generate menuentries that look vaguely like what's in this? Assuming it's grub, pressing AFAIK dracut's |
I just tested with fresh builds of base and xfce live images. They work fine with ventoy. It uses grub indeed but the menuentries are nothing like these of glim. |
fa0e82f
to
2165883
Compare
|
What do they look like? I tried digging through the ventoy repo and can't see anything |
Ventoy generates (on boot) a grub menu with a menu entry for every image available in the drive. The menuentry is simple - 2 lines of code. It chainloads and you actually use the bootloader of the image. |
Ah I see |
Is the image produced from mklive supposed to be used like this? Yes, that can be a problem, so dracut must be fixed :D |
Tested with base, xfce and enlightenment images generated from build-x86-image.sh.