Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: added on query to command (COR-1997) #557

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: added on query to command (COR-1997) #557

wants to merge 11 commits into from

Conversation

zhihil
Copy link
Contributor

@zhihil zhihil commented Oct 28, 2024 •
edited
Loading

Fixes or implements COR-1997

Brief description. What is this change?

Implementation details. How do you make this change?

Setup information

Deployment Notes

Related PRs

  1. [Merged by Bors] - feat: added on query to command (COR-1997) #557
  2. https://github.com/voiceflow/general-runtime/pull/1114

Checklist

  • Breaking changes have been communicated, including:
    • New required environment variables
    • Renaming of interfaces (API routes, request/response interface, etc)
  • New environment variables have been deployed
  • Appropriate tests have been written
    • Bug fixes are accompanied by an updated or new test
    • New features are accompanied by a new test

@linear Linear
Copy link

linear bot commented Oct 28, 2024

COR-1997 Add support for triggering a function-defined event after it has passed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zhihil
Copy link
Contributor Author

zhihil commented Oct 31, 2024

bors r+

bors-vf bot pushed a commit that referenced this pull request Oct 31, 2024
@zhihil
feat: added on query to command (COR-1997) (#557)
30c8ee0 
<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements COR-1997**

### Brief description. What is this change?

<!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->
@bors-vf
Copy link

bors-vf bot commented Oct 31, 2024

Build failed:

@zhihil
Copy link
Contributor Author

zhihil commented Oct 31, 2024

bors r+

bors-vf bot pushed a commit that referenced this pull request Oct 31, 2024
@zhihil
feat: added on query to command (COR-1997) (#557)
406dc44 
<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements COR-1997**

### Brief description. What is this change?

<!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->
@bors-vf
Copy link

bors-vf bot commented Oct 31, 2024

Pull request successfully merged into master.

Build succeeded:

@bors-vf bors-vf bot changed the title feat: added on query to command (COR-1997) [Merged by Bors] - feat: added on query to command (COR-1997) Oct 31, 2024
@bors-vf bors-vf bot closed this Oct 31, 2024
@bors-vf bors-vf bot deleted the brennan/persistent-listening/COR-1997 branch October 31, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanasarjanjughazyan sanasarjanjughazyan sanasarjanjughazyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhihil @sanasarjanjughazyan