Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: generic smtp provider for email notifications #18

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

lucasmenendez
Copy link
Contributor

@lucasmenendez lucasmenendez commented Sep 24, 2024

This PR replaces the current email notification service from the Sendgrid API with a generic SMTP implementation, allowing the email provider to be changed by simply updating envvars.

Some new code has been commented to be uncommented when #14 is merged.

@lucasmenendez lucasmenendez added the enhancement New feature or request label Sep 24, 2024
@lucasmenendez lucasmenendez self-assigned this Sep 24, 2024
@lucasmenendez lucasmenendez marked this pull request as ready for review September 24, 2024 15:35
notifications/smtp/smtp.go Outdated Show resolved Hide resolved
notifications/smtp/smtp.go Outdated Show resolved Hide resolved
notifications/smtp/smtp.go Outdated Show resolved Hide resolved
notifications/smtp/smtp.go Show resolved Hide resolved
@lucasmenendez lucasmenendez merged commit 987662a into main Sep 25, 2024
6 checks passed
@lucasmenendez lucasmenendez deleted the f/smtp_email_notifications branch September 25, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants