Use primaryLanguage instead of languages in repos per language query

[AleksaC]

The results of repos per language graph seemed odd to me. When I looked into it I noticed that the languageMap doesn't include many languages I have projects in. After further inspection I found out that the languages array is empty for private repos. I tried using primaryLanguages instead of languages field and it appears to be working correctly.

Here are the screenshots before and after the change.

[vn7n24fzkq]

@AleksaC Thanks for the contribution! 😄
But I cannot reproduction this situation, all of languages in my private repo are not empty in languageMap.
Probably is a github api issue, I will do more investigation to make sure we can merge this PR.

[vn7n24fzkq]

It's odd , when use primaryLanguages instead of languages , the size of languageMap is larger. 🤔
For each repo, primaryLanguages only contains one language and languages should contains one or more.

[AleksaC]

The reason I found is that languages was an empty array for all my private repos, and since I only use some languages in private repos they don't show up in the map

[AleksaC]

Either way I think it makes more sense to use primaryLanguage, unless there are cases where it doesn't return the correct language.

[vn7n24fzkq]

Either way I think it makes more sense to use primaryLanguage, unless there are cases where it doesn't return the correct language.

Yes, it would make more sense.
One of the reason to use languages not primaryLanguage is some languages in repo will not display if use primaryLanguage and there are some repos used more than one language, for example javascript with typescript, java with kotlin.

---

How many repos do you have?
If my memory serves well, the GitHub GraphQL API only allowed 100 repos per call for api pagination . And we only calculate for first 100 repos here, probably this is why the languageMap was not contains private repo languages.
We can consider to calculate for all repos.

[AleksaC]

One of the reason to use languages not primaryLanguage is some languages in repo will not display if use primaryLanguage and there are some repos used more than one language, for example javascript with typescript, java with kotlin.

This does not seem to be the case. From what I can see in the code you only include one language:

github-profile-summary-cards/src/github-api/repos-per-language.js

Line 64 in 369321b

let edge = node.languages.edges[0];

---

We can consider to calculate for all repos.

You already do:

github-profile-summary-cards/src/github-api/repos-per-language.js

Line 48 in 369321b

while (hasNextPage) {

I own 125 repos and you include all of them.

[vn7n24fzkq]

Oh, my mistake, seems my memory serves wrong. 😆
I think we can merge this PR right now.
But it is still weird that languages doesn't contain private repo language.
Thanks for your contributions again.

[AleksaC]

Yeah it's definitely weird, I'll see if I can a file an issue for that.

[vn7n24fzkq]

Yes, I am working for that.

[vn7n24fzkq]

@AleksaC It is released.
v0.3.3

[AleksaC]

Thanks!