vdk-control-cli: Make list command print all jobs on empty team param #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `list` command will now work when no team has been supplied as a parameter, in which case it will query for all teams. Some other small improvements have been made as well. Testing done: tested locally Signed-off-by: Gabriel Georgiev <[email protected]>
Signed-off-by: Gabriel Georgiev <[email protected]>
...k-plugins/vdk-plugin-control-cli/src/vdk/plugin/control_cli_plugin/vdk_plugin_control_cli.py
Outdated
Show resolved
Hide resolved
Be specific - what other small improvements? |
Signed-off-by: Gabriel Georgiev <[email protected]>
antoniivanov
approved these changes
Feb 17, 2022
...k-plugins/vdk-plugin-control-cli/src/vdk/plugin/control_cli_plugin/vdk_plugin_control_cli.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Gabriel Georgiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
listcommand will now work when no team has been supplied asa parameter, in which case it will query for all teams.
Additionally, the description of the logout command was fixed to say
"Control Service" instead of "Data Jobs Service" and an empty docstring
was removed.
Testing done: added unittest
Signed-off-by: Gabriel Georgiev [email protected]