Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: fix monthly download badges closing HTML tag #3090

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

yonitoo
Copy link
Contributor

@yonitoo yonitoo commented Feb 7, 2024

What: Add the missing closing tags for the monthly download badges.

Why: To fix the links in the READMEs.

Addresses this comment.

Before:
Without closing tag

After:
With closing tag

Signed-off by: Yoan Salambashev [email protected]

@antoniivanov
Copy link
Collaborator

Note that one chekc is failing

Error: PR title is not formatted correctly. Prefix must be one of: [pre-commit.ci], build(deps), vdk-<plugin-suffix>, <plugin-prefix>-vdk versatile-data-kit, specs, support, documentation, control-service, examples, frontend

@yonitoo yonitoo changed the title update READMEs: fix monthly download badges closing HTML tag documentation: fix monthly download badges closing HTML tag Feb 15, 2024
@yonitoo yonitoo merged commit 28ed822 into main Feb 15, 2024
14 of 17 checks passed
@yonitoo yonitoo deleted the topic/ysalambashev/fix-monthly-badges-closing-tag branch February 15, 2024 10:16
yonitoo added a commit that referenced this pull request Feb 15, 2024
What: Add the missing closing tags for the monthly download badges.

Why: To fix the links in the READMEs.

Addresses this
[comment](https://github.com/vmware/versatile-data-kit/pull/2983/files#r1467570214).

Before:
<img width="1011" alt="Without closing tag"
src="https://github.com/vmware/versatile-data-kit/assets/36246462/6717ca4d-0509-417a-a052-07864272a237">

After:
<img width="1011" alt="With closing tag"
src="https://github.com/vmware/versatile-data-kit/assets/36246462/fb6f7d99-f3b7-4b8b-bbc0-6b0adedc7b03">


Signed-off by: Yoan Salambashev <[email protected]>

Co-authored-by: Yoan Salambashev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants