control-service: Add support for vdk version #2943
Conversation
doks5
changed the title
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
5 times, most recently
from
eb75c32
to
b2acd7e
Compare
|
Please standardize the name to either vdkVersion or vdkImage. |
...pelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
3 times, most recently
from
33edbaa
to
7b269cf
Compare
|
We still have both |
@mivanov1988 Well, we cannot change the instances to vdkImage without changing the API in the same PR (without leaving the Control Service in a broken state). VDK version is passed in multiple APIs (deployment POST/PATCH) as part of DataJobDeployment, https://github.com/vmware/versatile-data-kit/blob/main/projects/control-service/projects/model/apidefs/datajob-api/api.yaml#L1133, and in GET as part of the DataJobDeploymentStatus, https://github.com/vmware/versatile-data-kit/blob/main/projects/control-service/projects/model/apidefs/datajob-api/api.yaml#L1170 and is then propagated throughout the different Control Service components. |
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
6 times, most recently
from
a1ed5c6
to
f3ea160
Compare
...lines_control_service/src/main/java/com/vmware/taurus/datajobs/DeploymentModelConverter.java
Outdated
Show resolved
Hide resolved
...lines_control_service/src/main/java/com/vmware/taurus/datajobs/DeploymentModelConverter.java
Outdated
Show resolved
Hide resolved
.../migration/V20231130230000__rename_column_vdk_version_to_vdk_image_in_datajob_executions.sql
Outdated
Show resolved
Hide resolved
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
5 times, most recently
from
cc947f9
to
b9313e7
Compare
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
7 times, most recently
from
e31470e
to
25d5464
Compare
..._control_service/src/main/java/com/vmware/taurus/service/deploy/SupportedPythonVersions.java
Outdated
Show resolved
Hide resolved
...pelines_control_service/src/main/java/com/vmware/taurus/service/deploy/JobImageDeployer.java
Outdated
Show resolved
Hide resolved
|
JobDeployerV2 should be changed as well. |
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
from
25d5464
to
b74123a
Compare
Good point. Fixed, thanks |
Currently, the vdk image used when a data job is deployed, is decided based on the python version. This is done in order to avoid possible incompatibility issues between the vdk image and the job base image. However, it also blocks the possibility to use testing vdk images in CI/CD acceptance tests. This change adds functionality that allows a client to pass a specific vdk image to be used for a data job deployment. This would allow for CI/CD tests to test specific vdk images before they are released. Testing Done: Unit and Integration tests Signed-off-by: Andon Andonov <[email protected]>
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
from
71a596a
to
88d2b9f
Compare
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
from
4bb8dc4
to
1257409
Compare
doks5
force-pushed
the
person/andonova/vdk-version-in-sync
branch
from
7d992d0
to
c2f0c28
Compare
Currently, the vdk image used when a data job is deployed, is decided based on the python version. This is done in order to avoid possible incompatibility issues between the vdk image and the job base image. However, it also blocks the possibility to use testing vdk images in CI/CD acceptance tests.
This change adds functionality that allows a client to pass a specific vdk image to be used for a data job deployment. This would allow for CI/CD tests to test specific vdk images before they are released.
Testing Done: Unit and Integration tests