vdk-notebook: Support for "%%vdkingest" cell type in Notebook Steps #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please include an example to the PR description |
duyguHsnHsn
reviewed
Nov 3, 2023
projects/vdk-plugins/vdk-notebook/tests/jobs/ingest-data-flow-job/steps.ipynb
Show resolved
Hide resolved
duyguHsnHsn
approved these changes
Nov 3, 2023
|
again i agree with Duygu. This needs good documentaiton. I can't really review till I see it. |
This commit introduces the ability to recognize and execute cells with the `%%vdkingest` magic function in notebook-based data jobs. Previously, notebook steps only supported Python and SQL cell types (`%%vdksql`). This addition enriches the functionality of notebook-based steps by providing users the capability to define ingestion tasks directly within a Jupyter notebook, enhancing flexibility and usability.
antoniivanov
force-pushed
the
person/aivanov/notebook
branch
from
47d923d
to
b4eb6d3
Compare
I added a sentence. But the meat of the documentation is meant to be in vdk-ipython and there's link in this README to it. The PR for vdk-ipython is #2866 |
murphp15
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to recognize and execute cells with the
%%vdkingestmagic function in notebook-based data jobs. Previously, notebook steps only supported Python and SQL cell types (%%vdksql).This addition enriches the functionality of notebook-based steps by providing users the capability to define ingestion tasks directly within a Jupyter notebook, enhancing flexibility and usability.