vdk-core: remove code duplication in ingestion router #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakodakov
requested changes
Oct 5, 2023
projects/vdk-core/src/vdk/internal/builtin_plugins/ingestion/ingester_router.py
Outdated
Show resolved
Hide resolved
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
from
e3e4a7b
to
4bdf036
Compare
gageorgiev
approved these changes
Oct 5, 2023
There would some code duplication in ingester router which even cause send_object_for_ingestion and send_tabular_data to handle method different which was subtle issue. Refactor to remove the code duplication and reduce the number of lines as a whole.
dakodakov
approved these changes
Oct 5, 2023
antoniivanov
force-pushed
the
person/aivanov/vdk-core-errors
branch
from
4bdf036
to
3f7dc73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There would some code duplication in ingester router which even cause send_object_for_ingestion and send_tabular_data to handle method different which was subtle issue.
Refactor to remove the code duplication and reduce the number of lines as a whole.