vdk-jupyter: fix bug in detecting run functions #2721
Merged
+111
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duyguHsnHsn
approved these changes
Sep 29, 2023
gageorgiev
approved these changes
Sep 29, 2023
antoniivanov
force-pushed
the
person/aivanov/jupyter-summary
branch
from
8755b5d
to
b1368e3
Compare
We are using `re.search(r"def run\(job_input", content)` which is very bad practice. Never use regex unless you have a official contract or specification that promises the regex will work. The regex breaks in so many cases : - put some space anywhere `def run<space>(job_input)` , - def run is defined on multiple lines - coments . - def run ins in string literal and not really a method - and probably much more I cannot think of. In general rule, I really think it's bad idea to do parsing (regex is type of parsing) without implement strict contract and specification. The solution to the problem here simple fortunately. It is to use Python's ast (Abstract Syntax Tree) module to parse Python code.
antoniivanov
force-pushed
the
person/aivanov/jupyter-summary
branch
from
b1368e3
to
81b29b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
re.search(r"def run\(job_input", content)which is very bad practice. Never use regex unless you have a official contract or specification that promises the regex will work.The regex breaks in so many cases :
def run<space>(job_input),In general rule, I really think it's bad idea to do parsing (regex is type of parsing) without implement strict contract and specification.
The solution to the problem here simple fortunately. It is to use Python's ast (Abstract Syntax Tree) module to parse Python code.