-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control-service: ability to set builder image per python version #2490
control-service: ability to set builder image per python version #2490
Commits on Jul 27, 2023
-
control-service: ability to set builder image per supported python ve…
…rsion Why Currently, we don't have the ability to set different builder image per supported Python version. This prevents us from VDK deployment which consists of regular and secure data job base images, since both builder implementations differ. What Introduced optional property to the supported python versions called `builderImage`: ``` {3.9: {vdkImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/quickstart-vdk:release', baseImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/data-job-base-python-3.9:latest', builderImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/job-builder:1.3.3'}}" ``` The property is optional if it is not present CS will default to the `datajobs.builder.image=registry.hub.docker.com/versatiledatakit/job-builder:1.3.3`. Testing Done: Unit and IT tests. Signed-off-by: Miroslav Ivanov [email protected]
Configuration menu - View commit details
-
Copy full SHA for 8ce7e34 - Browse repository at this point
Copy the full SHA 8ce7e34View commit details -
github-actions committed
Jul 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 81e999b - Browse repository at this point
Copy the full SHA 81e999bView commit details -
control-service: ability to set builder image per supported python ve…
…rsion Why Currently, we don't have the ability to set different builder image per supported Python version. This prevents us from VDK deployment which consists of regular and secure data job base images, since both builder implementations differ. What Introduced optional property to the supported python versions called `builderImage`: ``` {3.9: {vdkImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/quickstart-vdk:release', baseImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/data-job-base-python-3.9:latest', builderImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/job-builder:1.3.3'}}" ``` The property is optional if it is not present CS will default to the `datajobs.builder.image=registry.hub.docker.com/versatiledatakit/job-builder:1.3.3`. Testing Done: Unit and IT tests. Signed-off-by: Miroslav Ivanov [email protected]
Configuration menu - View commit details
-
Copy full SHA for fc20d72 - Browse repository at this point
Copy the full SHA fc20d72View commit details -
github-actions committed
Jul 27, 2023 Configuration menu - View commit details
-
Copy full SHA for c060749 - Browse repository at this point
Copy the full SHA c060749View commit details -
Configuration menu - View commit details
-
Copy full SHA for d1f5eca - Browse repository at this point
Copy the full SHA d1f5ecaView commit details -
github-actions committed
Jul 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 7bb266c - Browse repository at this point
Copy the full SHA 7bb266cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed3a8e6 - Browse repository at this point
Copy the full SHA ed3a8e6View commit details -
github-actions committed
Jul 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 7aa315f - Browse repository at this point
Copy the full SHA 7aa315fView commit details -
Merge main into person/miroslavi/make-data-job-builder-configurable-p…
…er-python-version
Configuration menu - View commit details
-
Copy full SHA for 5f9b040 - Browse repository at this point
Copy the full SHA 5f9b040View commit details -
Merge main into person/miroslavi/make-data-job-builder-configurable-p…
…er-python-version
Configuration menu - View commit details
-
Copy full SHA for ff82b81 - Browse repository at this point
Copy the full SHA ff82b81View commit details