Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

control-service: ability to set builder image per python version #2490

Merged
merged 10 commits into from
Jul 28, 2023
Merged

control-service: ability to set builder image per python version #2490

merged 10 commits into from
Jul 28, 2023

Commits on Jul 27, 2023

  1. control-service: ability to set builder image per supported python ve… 

    …rsion

Why
Currently, we don't have the ability to set different builder image per supported Python version. This prevents us from VDK deployment which consists of regular and secure data job base images, since both builder implementations differ.

What
Introduced optional property to the supported python versions called `builderImage`:

```
{3.9: {vdkImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/quickstart-vdk:release', baseImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/data-job-base-python-3.9:latest', builderImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/job-builder:1.3.3'}}"
```

The property is optional if it is not present CS will default to the `datajobs.builder.image=registry.hub.docker.com/versatiledatakit/job-builder:1.3.3`.

Testing Done:
Unit and IT tests.

Signed-off-by: Miroslav Ivanov [email protected]
    @mivanov1988
    mivanov1988 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8ce7e34 View commit details
    Browse the repository at this point in the history

  2. Google Java Format

    github-actions committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    81e999b View commit details
    Browse the repository at this point in the history

  3. control-service: ability to set builder image per supported python ve… 

    …rsion

Why
Currently, we don't have the ability to set different builder image per supported Python version. This prevents us from VDK deployment which consists of regular and secure data job base images, since both builder implementations differ.

What
Introduced optional property to the supported python versions called `builderImage`:

```
{3.9: {vdkImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/quickstart-vdk:release', baseImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/data-job-base-python-3.9:latest', builderImage: 'ghcr.io/versatile-data-kit-dev/versatiledatakit/job-builder:1.3.3'}}"
```

The property is optional if it is not present CS will default to the `datajobs.builder.image=registry.hub.docker.com/versatiledatakit/job-builder:1.3.3`.

Testing Done:
Unit and IT tests.

Signed-off-by: Miroslav Ivanov [email protected]
    @mivanov1988
    mivanov1988 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    fc20d72 View commit details
    Browse the repository at this point in the history

  4. Google Java Format

    github-actions committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    c060749 View commit details
    Browse the repository at this point in the history

  5. Google Java Format

    @mivanov1988
    github-actions authored and mivanov1988 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d1f5eca View commit details
    Browse the repository at this point in the history

  6. Google Java Format

    github-actions committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    7bb266c View commit details
    Browse the repository at this point in the history

  7. Google Java Format

    @mivanov1988
    github-actions authored and mivanov1988 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ed3a8e6 View commit details
    Browse the repository at this point in the history

  8. Google Java Format

    github-actions committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    7aa315f View commit details
    Browse the repository at this point in the history

  9. Merge main into person/miroslavi/make-data-job-builder-configurable-p… 

    …er-python-version
    @github-actions
    github-actions[bot] committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    5f9b040 View commit details
    Browse the repository at this point in the history

  10. Merge main into person/miroslavi/make-data-job-builder-configurable-p… 

    …er-python-version
    @github-actions
    github-actions[bot] committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ff82b81 View commit details
    Browse the repository at this point in the history