vdk-impala: support also pydantic 1.0 #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doks5
approved these changes
Jul 6, 2023
antoniivanov
force-pushed
the
person/aivanov/vdk-impala-fix
branch
from
a8d4378
to
9dd2513
Compare
Explained, thanks for the reminder. |
antoniivanov
force-pushed
the
person/aivanov/vdk-impala-fix
branch
from
9dd2513
to
387bc3f
Compare
gageorgiev
approved these changes
Jul 7, 2023
antoniivanov
force-pushed
the
person/aivanov/vdk-impala-fix
branch
from
387bc3f
to
9715350
Compare
Make sure vdk-impala works with pydantic 1.0 as this is still used and some libraries do not support the new version. In hindsight I probably should have pinned to 1.0 only . But I did not and it's good idea to support the new version otherwise at some point in the future it will cause conflicts and problems as other library adopted.
antoniivanov
force-pushed
the
person/aivanov/vdk-impala-fix
branch
from
9715350
to
70b2f4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure vdk-impala works with pydantic 1.0 as this is still used and libraries do not support the new version.
In hindsight, I should have pinned to 1.0 only. But I did not and it's a good idea to support the new version otherwise at some point it will cause conflicts and problems as other libraries adopt 2.0 of pydantic
Testing Done: installed locally pydantic 1.0 . The Gitlab CI is testing with 2
pip install pydantic==1.*I toyed with the idea of adding a test for pydanitc 1.0 but it would require some refactoring of hte plugin framework to allow that and it's not that urgent as the changes are fairly small.