-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specs: VEP-2272 Complete Data Job Configuration Persistence #2287
Merged
mivanov1988
merged 6 commits into
main
from
person/miroslavi/spec-complete-job-config-persistence-in-db
Jun 21, 2023
Merged
specs: VEP-2272 Complete Data Job Configuration Persistence #2287
mivanov1988
merged 6 commits into
main
from
person/miroslavi/spec-complete-job-config-persistence-in-db
Jun 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
specs/vep-2272-complete-data-job-configuration-persistence/README.md
Outdated
Show resolved
Hide resolved
specs/vep-2272-complete-data-job-configuration-persistence/README.md
Outdated
Show resolved
Hide resolved
dakodakov
reviewed
Jun 20, 2023
specs/vep-2272-complete-data-job-configuration-persistence/README.md
Outdated
Show resolved
Hide resolved
doks5
reviewed
Jun 20, 2023
specs/vep-2272-complete-data-job-configuration-persistence/README.md
Outdated
Show resolved
Hide resolved
specs/vep-2272-complete-data-job-configuration-persistence/README.md
Outdated
Show resolved
Hide resolved
specs/vep-2272-complete-data-job-configuration-persistence/README.md
Outdated
Show resolved
Hide resolved
I think you need to rebase your branch. A lot of stuff there :) |
specs/vep-2272-complete-data-job-configuration-persistence/deploy_data_job_diagram.puml
Show resolved
Hide resolved
antoniivanov
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's merge it and tackle next sections in subsequent PR?
But it's good idea to update the diagrams before that if you can.
Signed-off-by: [email protected]
This change introduces VEP-2272, which aims at proposing an improvement to Versatile Data Kit by switching the source of truth from Kubernetes to a database. Note: This PR will cover only the first four sections. Signed-off-by: Miroslav Ivanov [email protected]
This change introduces VEP-2272, which aims at proposing an improvement to Versatile Data Kit by switching the source of truth from Kubernetes to a database. Note: This PR will cover only the first four sections. Signed-off-by: Miroslav Ivanov [email protected]
This change introduces VEP-2272, which aims at proposing an improvement to Versatile Data Kit by switching the source of truth from Kubernetes to a database. Note: This PR will cover only the first four sections. Signed-off-by: Miroslav Ivanov [email protected]
This change introduces VEP-2272, which aims at proposing an improvement to Versatile Data Kit by switching the source of truth from Kubernetes to a database. Note: This PR will cover only the first four sections. Signed-off-by: Miroslav Ivanov [email protected]
e0a5fe0
to
30c93d5
Compare
This change introduces VEP-2272, which aims at proposing an improvement to Versatile Data Kit by switching the source of truth from Kubernetes to a database. Note: This PR will cover only the first four sections. Signed-off-by: Miroslav Ivanov [email protected]
dakodakov
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces VEP-2272, which aims at proposing an improvement
to Versatile Data Kit by switching the source of truth
from Kubernetes to a database.
Note: This PR will cover only the first four sections.
Signed-off-by: Miroslav Ivanov [email protected]