Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs: VEP-2272 Complete Data Job Configuration Persistence #2287

Merged

Conversation

mivanov1988
Copy link
Collaborator

@mivanov1988 mivanov1988 commented Jun 20, 2023

This change introduces VEP-2272, which aims at proposing an improvement
to Versatile Data Kit by switching the source of truth
from Kubernetes to a database.

Note: This PR will cover only the first four sections.

Signed-off-by: Miroslav Ivanov [email protected]

@antoniivanov
Copy link
Collaborator

I think you need to rebase your branch. A lot of stuff there :)

Copy link
Collaborator

@antoniivanov antoniivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's merge it and tackle next sections in subsequent PR?

But it's good idea to update the diagrams before that if you can.

This change introduces VEP-2272, which aims at proposing an improvement
to Versatile Data Kit by switching the source of truth
from Kubernetes to a database.

Note: This PR will cover only the first four sections.

Signed-off-by: Miroslav Ivanov [email protected]
This change introduces VEP-2272, which aims at proposing an improvement
to Versatile Data Kit by switching the source of truth
from Kubernetes to a database.

Note: This PR will cover only the first four sections.

Signed-off-by: Miroslav Ivanov [email protected]
This change introduces VEP-2272, which aims at proposing an improvement
to Versatile Data Kit by switching the source of truth
from Kubernetes to a database.

Note: This PR will cover only the first four sections.

Signed-off-by: Miroslav Ivanov [email protected]
This change introduces VEP-2272, which aims at proposing an improvement
to Versatile Data Kit by switching the source of truth
from Kubernetes to a database.

Note: This PR will cover only the first four sections.

Signed-off-by: Miroslav Ivanov [email protected]
@mivanov1988 mivanov1988 force-pushed the person/miroslavi/spec-complete-job-config-persistence-in-db branch from e0a5fe0 to 30c93d5 Compare June 21, 2023 13:07
This change introduces VEP-2272, which aims at proposing an improvement
to Versatile Data Kit by switching the source of truth
from Kubernetes to a database.

Note: This PR will cover only the first four sections.

Signed-off-by: Miroslav Ivanov [email protected]
@mivanov1988 mivanov1988 enabled auto-merge (squash) June 21, 2023 13:37
@mivanov1988 mivanov1988 merged commit 75e736c into main Jun 21, 2023
9 checks passed
@mivanov1988 mivanov1988 deleted the person/miroslavi/spec-complete-job-config-persistence-in-db branch June 21, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants