control-service: better error message #2094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
At the moment if a test fails to setup correctly it is almost impossible to figure out why it failed when investigating even 5 minutes later.
What
With this PR I add a new assertion. instead of checking if a cron job for a data job is deployed I first check that the builder job completed successfully.
If the builder fails, I include the logs in the stacktrace which means it is very easy to understand the root cause at a later date.
How was this tested
Locally
Example stacktrace when builder fails.