Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update apiClient #231

Merged
merged 1 commit into from
Aug 22, 2024
Merged

refactor: update apiClient #231

merged 1 commit into from
Aug 22, 2024

Conversation

tenthirtyam
Copy link
Collaborator

@tenthirtyam tenthirtyam commented Aug 21, 2024

In order to have a good experience with our community, we recommend that you read the contributing guidelines for making a pull request.

Summary of Pull Request

Update apiClient to be more concise, where applicable.

This is preferred in Go for its brevity and clarity.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@tenthirtyam tenthirtyam added the refactor Refactor label Aug 21, 2024
@tenthirtyam tenthirtyam added this to the v0.11.0 milestone Aug 21, 2024
@tenthirtyam tenthirtyam self-assigned this Aug 21, 2024
@github-actions github-actions bot added needs-review Needs Review provider Provider labels Aug 21, 2024
@tenthirtyam tenthirtyam force-pushed the refactor/update-apiClient branch 2 times, most recently from 6e7929f to 9004de6 Compare August 21, 2024 18:41
Update `apiClient` to be more concise, where applicable.

This is preferred in Go for its brevity and clarity.

Signed-off-by: Ryan Johnson <[email protected]>
@tenthirtyam tenthirtyam marked this pull request as ready for review August 22, 2024 07:59
@tenthirtyam tenthirtyam merged commit bf1b271 into main Aug 22, 2024
9 checks passed
@tenthirtyam tenthirtyam deleted the refactor/update-apiClient branch August 22, 2024 08:07
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Aug 22, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
provider Provider refactor Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants