Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add examples for PAIF automation #168

Merged
merged 4 commits into from
May 10, 2024
Merged

feat: Add examples for PAIF automation #168

merged 4 commits into from
May 10, 2024

Conversation

spacegospod
Copy link
Contributor

Summary of Pull Request

Adding sample configuration files for the Private AI workflow - Supervisor cluster with NSX networking and a custom ESXi image with vGPU drivers.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe: Configuration examples

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@spacegospod spacegospod self-assigned this May 9, 2024
@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels May 9, 2024
Copy link
Contributor

@dimitarproynov dimitarproynov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO at the start of each step we should state the goal of the step.

@tenthirtyam
Copy link
Collaborator

Would it be better to make these modules?

@spacegospod
Copy link
Contributor Author

Would it be better to make these modules?

It might just be. I'm not sure if I can publish a module from the provider's repository though.
I will see what I can do, worst case scenario - I will have to create another repo under /vmware

Copy link
Contributor

@dimitarproynov dimitarproynov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im fine to have this in the provider repo AND as modules in some other repo

@spacegospod spacegospod merged commit a5ee36c into main May 10, 2024
7 checks passed
@spacegospod
Copy link
Contributor Author

@tenthirtyam I'm not giving up on the modules idea. I just want to have both the examples AND the modules.

I even went ahead and uploaded a module for edge clusters. It supports a variable number of edge nodes, uplinks, bgp peers all the good stuff.

@spacegospod spacegospod deleted the feat/paif-samples branch May 16, 2024 10:47
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jun 12, 2024
@vmware vmware locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants