Adjust vcd_nsxt_alb_settings to support IPv6 and Transparent mode #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
reviewed
Feb 15, 2023
Signed-off-by: Dainius Serplis <[email protected]>
lvirbalas
approved these changes
Feb 20, 2023
adambarreiro
approved these changes
Feb 20, 2023
adezxc
reviewed
Mar 2, 2023
dataclouder
approved these changes
Mar 2, 2023
adezxc
approved these changes
Mar 2, 2023
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs builds on top of vmware/go-vcloud-director#549 and adds two new fields to
vcd_nsxt_alb_settingsresource and data source:ipv6_service_network_specification(requires VCD 10.4.0+).is_transparent_mode_enabled(requires VCD 10.4.1+). This field allows using a "Preserve Client IP" on a Virtual Service. Note. The Virtual Service resource (vcd_nsxt_alb_virtual_service) will be updated in separate PRs during this release cycle.