NSX-V distributed firewall resource and data source #988

dataclouder · 2023-01-30T12:40:46Z

This PR adds

a resource for vcd_nsxv_distributed_firewall
a data source for vcd_nsxv_distributed_firewall
a data source for vcd_nsxv_application_finder, to find applications and application groups to use with the NSX-V distributed firewall.
a data source for vcd_nsxv_application to read an application to use with the NSXV distributed firewall
a data source for vcd_nsxv_application_group to read an application group to use with the NSX-V distributed firewall
a new property for vcd_org_vdc resource and data source: enable_distributed_firewall, which allows sys admins to enable the firewall when creating a VDC.

NOTE: As per product specs, no default rules are added. Users are free to set or remove rules without constraints. If users want to set a default rule (such as a "fallback deny all") they must add it explicitly.

Signed-off-by: Giuseppe Maxia <[email protected]>

lvirbalas

Thanks for tune-ups!

Signed-off-by: Giuseppe Maxia <[email protected]>

adambarreiro

First scan, just some nits and doubts.

vcd/datasource_vcd_nsxv_distributed_firewall.go

vcd/resource_vcd_nsxv_distributed_firewall.go

website/docs/d/nsxv_application.html.markdown

website/docs/d/nsxv_application_finder.html.markdown

Signed-off-by: Giuseppe Maxia <[email protected]>

Didainius

Looks good while testing. Some inline comments.
I also saw some TODO items - are these fine to leave now, or should any of them be reevaluated?

website/docs/r/nsxv_distributed_firewall.html.markdown

vcd/resource_vcd_nsxv_distributed_firewall.go

vcd/datasource_vcd_org_vdc.go

vcd/datasource_vcd_nsxv_application_finder.go

Signed-off-by: Giuseppe Maxia <[email protected]>

.changes/v3.9.0/988-improvements.md

website/docs/d/nsxv_application.html.markdown

website/docs/d/nsxv_application_group.html.markdown

Signed-off-by: Giuseppe Maxia <[email protected]>

Upon accurate testing, the empty elements are the result of processing an empty set. Such elements must be skipped Signed-off-by: Giuseppe Maxia <[email protected]>

adambarreiro

Amazing work, thanks!

vcd/datasource_not_found_test.go

Signed-off-by: Giuseppe Maxia <[email protected]>

Giuseppe Maxia added 25 commits January 30, 2023 13:38

Add provisional NSXV distributed firewall data source

3263db5

Signed-off-by: Giuseppe Maxia <[email protected]>

Update go.mod

ba04ce1

Signed-off-by: Giuseppe Maxia <[email protected]>

Add "enable_distributed_firewall" to VDC resource and data source

52d0d00

Signed-off-by: Giuseppe Maxia <[email protected]>

[WIP] add resource vcd_nsxv_distributed_firewall

a3f5dbe

Signed-off-by: Giuseppe Maxia <[email protected]>

Add data sources to handle distributed firewall services

d6ea11a

Signed-off-by: Giuseppe Maxia <[email protected]>

Update go.mod

703c86d

Signed-off-by: Giuseppe Maxia <[email protected]>

Adjust TestAccDataSourceNotFound to run vcd_nsxv_distributed_firewall

833a8fd

Signed-off-by: Giuseppe Maxia <[email protected]>

Tune up NSXV firewall services data sources

f40ae35

Signed-off-by: Giuseppe Maxia <[email protected]>

[WIP] Implement CRUD for NSXV distributed firewall

99ba712

Signed-off-by: Giuseppe Maxia <[email protected]>

Finalize data source vcd_nsxv_distributed_firewall

ff789f6

Signed-off-by: Giuseppe Maxia <[email protected]>

Convert rule internal lists to sets

95ed483

Signed-off-by: Giuseppe Maxia <[email protected]>

Add initial test for vcd_nsxv_distributed_firewall

b8a333d

Signed-off-by: Giuseppe Maxia <[email protected]>

Update NSXV distributed firewall test

f40fdd6

Signed-off-by: Giuseppe Maxia <[email protected]>

Add documentation

0425dd0

Signed-off-by: Giuseppe Maxia <[email protected]>

Merge branch 'main' into distributed-firewall-1

d4c7cb0

Signed-off-by: Giuseppe Maxia <[email protected]>

Update go.mod

3475627

Signed-off-by: Giuseppe Maxia <[email protected]>

Update docs

be3cf04

Signed-off-by: Giuseppe Maxia <[email protected]>

Add validation for rule elements

fd3e955

Signed-off-by: Giuseppe Maxia <[email protected]>

Update docs

b658228

Signed-off-by: Giuseppe Maxia <[email protected]>

Update docs

b22aa48

Signed-off-by: Giuseppe Maxia <[email protected]>

Add import feature to vcd_nsxv_distributed_firewall

e2d1f39

Signed-off-by: Giuseppe Maxia <[email protected]>

Rename service* entities to application*

689cfa4

Signed-off-by: Giuseppe Maxia <[email protected]>

Add test for vcd_nsxv_application_finder

b3ef114

Signed-off-by: Giuseppe Maxia <[email protected]>

Add import info to docs

fd59516

Signed-off-by: Giuseppe Maxia <[email protected]>

Add valudation funcs to some rule elements

58e5278

Signed-off-by: Giuseppe Maxia <[email protected]>

lvirbalas changed the title ~~NSXV distributed firewall resource and data source~~ NSX-V distributed firewall resource and data source Mar 1, 2023

Giuseppe Maxia added 4 commits March 3, 2023 06:58

Add NSX-V distributed firewall multi-provider test

8b1d0c0

Signed-off-by: Giuseppe Maxia <[email protected]>

Add CHANGELOG entries

2b5e926

Signed-off-by: Giuseppe Maxia <[email protected]>

Fix discrepancy in schema definition

7e029dc

Signed-off-by: Giuseppe Maxia <[email protected]>

Improve test to run both in integrated and binary

f540607

Signed-off-by: Giuseppe Maxia <[email protected]>

lvirbalas approved these changes Mar 6, 2023

View reviewed changes

Giuseppe Maxia added 3 commits March 7, 2023 09:54

Change property "enabled" to Computed

5818203

Signed-off-by: Giuseppe Maxia <[email protected]>

Update docs

c7af4df

Signed-off-by: Giuseppe Maxia <[email protected]>

Fix docs examples formatting

72cab8d

Signed-off-by: Giuseppe Maxia <[email protected]>

adambarreiro reviewed Mar 8, 2023

View reviewed changes

Giuseppe Maxia added 3 commits March 8, 2023 14:05

Update go.mod

6a0e812

Signed-off-by: Giuseppe Maxia <[email protected]>

Merge branch 'main' into distributed-firewall-1

6a40f45

Signed-off-by: Giuseppe Maxia <[email protected]>

Update go.mod

2cdf7d4

Signed-off-by: Giuseppe Maxia <[email protected]>

Didainius reviewed Mar 9, 2023

View reviewed changes

Giuseppe Maxia added 7 commits March 9, 2023 13:15

Update docs

66aca67

Signed-off-by: Giuseppe Maxia <[email protected]>

Rename enable_distributed_firewall to enable_nsxv_distributed_firewall

1de92df

Signed-off-by: Giuseppe Maxia <[email protected]>

Fix properties description

6a7e1ef

Signed-off-by: Giuseppe Maxia <[email protected]>

Update description and fix import bug

cca187d

Signed-off-by: Giuseppe Maxia <[email protected]>

Fix naming issue

c6b921b

Signed-off-by: Giuseppe Maxia <[email protected]>

Improve error messages

8f9d1b2

Signed-off-by: Giuseppe Maxia <[email protected]>

Improve test formatting

63d0374

Signed-off-by: Giuseppe Maxia <[email protected]>

lvirbalas reviewed Mar 9, 2023

View reviewed changes

.changes/v3.9.0/988-improvements.md Outdated Show resolved Hide resolved

lvirbalas reviewed Mar 9, 2023

View reviewed changes

website/docs/d/nsxv_application.html.markdown Outdated Show resolved Hide resolved

website/docs/d/nsxv_application_group.html.markdown Outdated Show resolved Hide resolved

Giuseppe Maxia added 2 commits March 9, 2023 15:20

Fix changelog entry

0fbbc68

Signed-off-by: Giuseppe Maxia <[email protected]>

Update docs

a42ef56

Signed-off-by: Giuseppe Maxia <[email protected]>

Didainius approved these changes Mar 10, 2023

View reviewed changes

Giuseppe Maxia added 3 commits March 10, 2023 13:03

Merge branch 'main' into distributed-firewall-1

d92f3c2

Signed-off-by: Giuseppe Maxia <[email protected]>

update go.mod

09a8ddd

Signed-off-by: Giuseppe Maxia <[email protected]>

Remove TODO comments

b919d8f

Upon accurate testing, the empty elements are the result of processing an empty set. Such elements must be skipped Signed-off-by: Giuseppe Maxia <[email protected]>

adambarreiro approved these changes Mar 14, 2023

View reviewed changes

adezxc approved these changes Mar 14, 2023

View reviewed changes

vcd/datasource_not_found_test.go Outdated Show resolved Hide resolved

Giuseppe Maxia added 2 commits March 14, 2023 09:32

Update comments in testSpecificDataSourceNotFound

936f993

Signed-off-by: Giuseppe Maxia <[email protected]>

Update go.mod

b6bb641

Signed-off-by: Giuseppe Maxia <[email protected]>

dataclouder merged commit 60d8d65 into vmware:main Mar 14, 2023

dataclouder deleted the distributed-firewall-1 branch November 20, 2023 10:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NSX-V distributed firewall resource and data source #988

NSX-V distributed firewall resource and data source #988

dataclouder commented Jan 30, 2023 •

edited

Loading

lvirbalas left a comment

adambarreiro left a comment

Didainius left a comment

adambarreiro left a comment

NSX-V distributed firewall resource and data source #988

NSX-V distributed firewall resource and data source #988

Conversation

dataclouder commented Jan 30, 2023 • edited Loading

lvirbalas left a comment

Choose a reason for hiding this comment

adambarreiro left a comment

Choose a reason for hiding this comment

Didainius left a comment

Choose a reason for hiding this comment

adambarreiro left a comment

Choose a reason for hiding this comment

dataclouder commented Jan 30, 2023 •

edited

Loading