Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix catalog access #972

Merged
merged 24 commits into from
Jan 9, 2023
Merged

Fix catalog access #972

merged 24 commits into from
Jan 9, 2023

Conversation

dataclouder
Copy link
Contributor

@dataclouder dataclouder commented Jan 2, 2023 •
edited
Loading

This PR does the following:

Giuseppe Maxia added 9 commits January 2, 2023 13:36
Add framework for testing with multiple orgs
ec91fb3 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update docs
d3b7a2d 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update govcd commit
e430e2a 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add test for multi-org access of shared catalog
adfcc38 
Signed-off-by: Giuseppe Maxia <[email protected]>
Change access of catalog entities without full Org
df988b7 
All catalog related entities can be accessed without a full Org
object. This allows accessing shared catalogs and their contents

Signed-off-by: Giuseppe Maxia <[email protected]>
Fix staticcheck error
ef91ece 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add changelog items
c1cc246 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update provider version
2c4164e 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add test for catalog subscription from vSphere
6286299 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder marked this pull request as ready for review January 3, 2023 11:41
Update CHANGELOG items
fe5bf16 
Signed-off-by: Giuseppe Maxia <[email protected]>
adambarreiro
adambarreiro reviewed Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First scan, just a few doubts from my side

.changes/v3.8.2/972-bug-fixes.md Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_media.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_media.go Show resolved Hide resolved
vcd/resource_vcd_catalog_media.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_media.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_media.go Show resolved Hide resolved
vcd/resource_vcd_catalog_vapp_template.go Show resolved Hide resolved
website/docs/d/catalog_media.html.markdown Outdated Show resolved Hide resolved
website/docs/r/catalog_media.html.markdown Outdated Show resolved Hide resolved
Giuseppe Maxia added 4 commits January 4, 2023 14:16
Improve media item schema definition
8a31929 
Signed-off-by: Giuseppe Maxia <[email protected]>
Add timing control to subscribed catalog tests
2907116 
Signed-off-by: Giuseppe Maxia <[email protected]>
Updata changelog entries
32070bc 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update docs
6d65fc0 
Signed-off-by: Giuseppe Maxia <[email protected]>
This was referenced Jan 4, 2023
Closed
Closed
Giuseppe Maxia added 3 commits January 4, 2023 19:26
Clean up catalog related docs
5f94523 
* Remove unnecessary "show_upload_progress"
* Change "true" and "false" strings to corresponding unquoted Boolean values

Signed-off-by: Giuseppe Maxia <[email protected]>
Format docs examples
d21b2db 
Signed-off-by: Giuseppe Maxia <[email protected]>
Replace quoted Boolean values with unquoted ones
bf10cef 
Signed-off-by: Giuseppe Maxia <[email protected]>
adambarreiro
adambarreiro reviewed Jan 5, 2023
View reviewed changes
vcd/resource_vcd_catalog_media.go Outdated Show resolved Hide resolved
vcd/resource_vcd_catalog_media.go Outdated Show resolved Hide resolved
lvirbalas
lvirbalas approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this, not a trivial PR, after all!

Giuseppe Maxia added 3 commits January 5, 2023 13:57
Improve error messages
c3d8f99 
Signed-off-by: Giuseppe Maxia <[email protected]>
Improve description and remove unneded check
5aa0a37 
Signed-off-by: Giuseppe Maxia <[email protected]>
Remove leftover comment
671cc3b 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder mentioned this pull request Jan 5, 2023
Closed
Fix TestAccDataSourceNotFound test
f7f3a46 
Signed-off-by: Giuseppe Maxia <[email protected]>
Update go.mod
a167483 
Signed-off-by: Giuseppe Maxia <[email protected]>
@dataclouder dataclouder merged commit c8e8092 into vmware:main Jan 9, 2023
@lvirbalas
Copy link
Collaborator

@dataclouder Please also add to the PR description that it deprecates usage of catalog in favor of catalog_id.

@dataclouder dataclouder deleted the fix-catalog-access branch November 20, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Didainius Didainius Didainius approved these changes

@lvirbalas lvirbalas lvirbalas approved these changes

@adambarreiro adambarreiro adambarreiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dataclouder @lvirbalas @adambarreiro @Didainius