Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IP Space Uplink Interface association #1311

Merged
merged 11 commits into from
Sep 3, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Aug 28, 2024

Closes #1207

This PR adds support for IP Space Uplink associations for particulat NSX-T Tier-0 router (aka "Provider gateways" in VCD) interfaces on VCD 10.5.0+
Two things are implemented:

  • New data source vcd_nsxt_tier0_router_interface to lookup Tier-0 Router Interfaces
  • associated_interface_ids in resource vcd_ip_space_uplink

It also requires new tier0routerInterface field in test config.
Tests with prefix TestAccVcdIpSpace* (covers all IP Space tests) passed on 10.5.1 and 10.6.0

Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius marked this pull request as ready for review August 30, 2024 11:02
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and tests passed on 10.6.0

Signed-off-by: Dainius Serplis <[email protected]>
@Didainius Didainius merged commit 085ac9c into vmware:main Sep 3, 2024
3 checks passed
@Didainius Didainius deleted the assign-interfaces branch September 3, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assign interfaces in vcd_ip_space_uplink
3 participants