Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vcd_external_endpoint and vcd_api_filter resources and data sources #1295

Merged
merged 23 commits into from
Jul 29, 2024

Conversation

adambarreiro
Copy link
Collaborator

@adambarreiro adambarreiro commented Jul 15, 2024

Description

This PR adds:

  • Resource and data source vcd_external_endpoint that allows to configure an External endpoint in VCD. External Endpoints is what API Filters consume to know the destination of the requests that match with the filter rules.
  • Resource and data source vcd_api_filter that links an External endpoint with some rules to match requests, so VCD can make the proper redirections.

The data source vcd_api_filter only works with ID as it's the only element that identifies an API Filter. In other words, there can be many API Filters with same External Endpoint reference, same pattern and same scope.

Closes #1213

Tests

Acceptance tests passed in VCD 10.6.0. Also binary tests.

abarreiro added 4 commits July 15, 2024 14:30
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro changed the title Add vcd_external_endpoint resource and data source Add vcd_external_endpoint and vcd_api_filter resources and data sources Jul 17, 2024
@adambarreiro adambarreiro self-assigned this Jul 17, 2024
abarreiro added 14 commits July 17, 2024 12:16
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
sdk
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
#
Signed-off-by: abarreiro <[email protected]>
@adambarreiro adambarreiro marked this pull request as ready for review July 22, 2024 09:45
@adambarreiro adambarreiro removed the request for review from dataclouder July 22, 2024 09:50
abarreiro added 2 commits July 29, 2024 09:05
Signed-off-by: abarreiro <[email protected]>
Signed-off-by: abarreiro <[email protected]>
Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@vmwclabot

This comment was marked as resolved.

1 similar comment
@vmwclabot

This comment was marked as resolved.

Signed-off-by: abarreiro <[email protected]>
abarreiro added 2 commits July 29, 2024 12:37
Copy link
Collaborator

@Didainius Didainius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have tried manual manipulation, ran test and binary test

@adambarreiro adambarreiro merged commit ea2e7cd into vmware:main Jul 29, 2024
3 checks passed
@adambarreiro adambarreiro deleted the add-external-endpoint branch July 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for vCD HTTP Transparent Proxy
4 participants