Add secondary IP address (IPv6) management to vcd_vapp_vm and vcd_vm #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
changed the title
Didainius
changed the title
Signed-off-by: Dainius Serplis <[email protected]>
Didainius
requested review from
lvirbalas,
adambarreiro and
dataclouder
as code owners
lvirbalas
approved these changes
Jul 11, 2024
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
Signed-off-by: Dainius Serplis <[email protected]>
adambarreiro
approved these changes
Jul 30, 2024
Signed-off-by: Dainius Serplis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1100
Note. This PR includes #1293 (version bump PR)
About
This PR adds support for secondary IP configuration option in
vcd_vmandvcd_vapp_vmby adding two new fields innetworkblock -secondary_ip_allocation_modeandsecondary_ip. Such names are chosen because they match other places with IPv6 support - e.g. routed network secondary IP poolsTesting
Ran tests for
vappandvmtags.Note. There are a few unrelated failures (might fail depending on the environment configuration) that need addressing separately.
Binary tests for new test
TestAccVcdVAppVm_4types_Ipv6in: